address feedback

Author: trueadm

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js

@@ -1,4 +1,4 @@
-/** @import { AssignmentExpression, Expression, Identifier, Pattern, PrivateIdentifier, Super, UpdateExpression, VariableDeclarator } from 'estree' */
+/** @import { AssignmentExpression, Expression, Literal, Pattern, PrivateIdentifier, Super, UpdateExpression, VariableDeclarator } from 'estree' */
 /** @import { AST, Binding } from '#compiler' */
 /** @import { AnalysisState, Context } from '../../types' */
 /** @import { Scope } from '../../../scope' */
@@ -176,25 +176,42 @@ export function is_safe_identifier(expression, scope) {
 }
 
 /**
- * @param {Expression | Super} node
+ * @param {Expression | Literal | Super} node
  * @param {Context} context
  * @returns {boolean}
  */
 export function is_pure(node, context) {
+	if (node.type === 'Literal') {
+		return true;
+	}
+	if (node.type === 'CallExpression') {
+		if (!is_pure(node.callee, context)) {
+			return false;
+		}
+		for (let arg of node.arguments) {
+			if (!is_pure(arg.type === 'SpreadElement' ? arg.argument : arg, context)) {
+				return false;
+			}
+		}
+		return true;
+	}
 	if (node.type !== 'Identifier' && node.type !== 'MemberExpression') {
 		return false;
 	}
 
-	if (node.type === 'MemberExpression' && node.object.type === 'Literal') {
-		return true;
+	/** @type {Expression | Super | null} */
+	let left = node;
+	while (left.type === 'MemberExpression' && !left.computed) {
+		left = left.object;
 	}
 
-	const left = object(node);
 	if (!left) return false;
 
 	if (left.type === 'Identifier') {
 		const binding = context.state.scope.get(left.name);
 		if (binding === null) return true; // globals are assumed to be safe
+	} else if (is_pure(left, context)) {
+		return true;
 	}
 
 	// TODO add more cases (safe Svelte imports, etc)

packages/svelte/tests/runtime-legacy/samples/inline-expressions-2/_config.js

@@ -6,5 +6,6 @@ export default test({
 		<p>With text expression: 7.36</p>
 		<p>With text expression and function call: 7.36</p>
 		<p>With text expression and property access: 4</p>
+		<h1>Hello name!</h1>
 		<p>4</p>`
 });

packages/svelte/tests/runtime-legacy/samples/inline-expressions-2/main.svelte

@@ -2,4 +2,5 @@
 <p>With text expression: {7.36}</p>
 <p>With text expression and function call: {(7.36).toLocaleString()}</p>
 <p>With text expression and property access: {"test".length}</p>
+<h1>Hello {('name').toUpperCase().toLowerCase()}!</h1>
 <p>{"test".length}</p>