Skip to content

Commit 3d161ee

Browse files
committed
avoid [[object Object]] in labels
1 parent 8a416a8 commit 3d161ee

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

packages/svelte/src/internal/client/dev/tracing.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,3 +189,13 @@ export function tag(source, name) {
189189
source.trace_name = name;
190190
return source;
191191
}
192+
193+
/**
194+
* @param {unknown} value
195+
*/
196+
export function label(value) {
197+
if (typeof value === 'symbol') return `Symbol(${value.description})`;
198+
if (typeof value === 'function') return '<function>';
199+
if (typeof value === 'object' && value) return '<object>';
200+
return String(value);
201+
}

packages/svelte/src/reactivity/map.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/** @import { Source } from '#client' */
22
import { DEV } from 'esm-env';
33
import { set, source } from '../internal/client/reactivity/sources.js';
4-
import { tag } from '../internal/client/dev/tracing.js';
4+
import { label, tag } from '../internal/client/dev/tracing.js';
55
import { get } from '../internal/client/runtime.js';
66
import { increment } from './utils.js';
77

@@ -90,8 +90,7 @@ export class SvelteMap extends Map {
9090
s = source(0);
9191

9292
if (DEV) {
93-
var label = `SvelteMap Entry [${typeof key === 'symbol' ? `Symbol(${key.description})` : key}]`;
94-
tag(s, label);
93+
tag(s, `SvelteMap get(${label(key)})`);
9594
}
9695

9796
sources.set(key, s);
@@ -127,8 +126,7 @@ export class SvelteMap extends Map {
127126
s = source(0);
128127

129128
if (DEV) {
130-
var label = `SvelteMap Entry [${typeof key === 'symbol' ? `Symbol(${key.description})` : key}]`;
131-
tag(s, label);
129+
tag(s, `SvelteMap get(${label(key)})`);
132130
}
133131

134132
sources.set(key, s);
@@ -159,8 +157,7 @@ export class SvelteMap extends Map {
159157
s = source(0);
160158

161159
if (DEV) {
162-
var label = `SvelteMap Entry [${typeof key === 'symbol' ? `Symbol(${key.description})` : key}]`;
163-
tag(s, label);
160+
tag(s, `SvelteMap get(${label(key)})`);
164161
}
165162

166163
sources.set(key, s);
@@ -225,8 +222,7 @@ export class SvelteMap extends Map {
225222
var s = source(0);
226223

227224
if (DEV) {
228-
var label = `SvelteMap Entry [${typeof key === 'symbol' ? `Symbol(${key.description})` : key}]`;
229-
tag(s, label);
225+
tag(s, `SvelteMap get(${label(key)})`);
230226
}
231227

232228
sources.set(key, s);

packages/svelte/src/reactivity/set.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/** @import { Source } from '#client' */
22
import { DEV } from 'esm-env';
33
import { source, set } from '../internal/client/reactivity/sources.js';
4-
import { tag } from '../internal/client/dev/tracing.js';
4+
import { label, tag } from '../internal/client/dev/tracing.js';
55
import { get } from '../internal/client/runtime.js';
66
import { increment } from './utils.js';
77

@@ -119,8 +119,7 @@ export class SvelteSet extends Set {
119119
s = source(true);
120120

121121
if (DEV) {
122-
var label = `SvelteSet Entry [${typeof value === 'symbol' ? `Symbol(${value.description})` : value}]`;
123-
tag(s, label);
122+
tag(s, `SvelteSet has(${label(value)})`);
124123
}
125124

126125
sources.set(value, s);

0 commit comments

Comments
 (0)