Skip to content

Commit 474155b

Browse files
committed
improved date tests
1 parent d59a51a commit 474155b

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

packages/svelte/src/reactivity/date.test.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -598,14 +598,16 @@ test('date fine grained tests', () => {
598598
getUTCHours: true,
599599
getMinutes: true,
600600
getUTCMinutes: true,
601+
getSeconds: true,
602+
getUTCSeconds: true,
601603
getMilliseconds: true,
602604
getUTCMilliseconds: true
603605
};
604606
let test_description: string = '';
605607

606-
const reset_change = () => {
607-
for (const key of Object.keys(changes)) {
608-
changes[key] = false;
608+
const expect_all_changes_to_be_false = () => {
609+
for (const key of Object.keys(changes) as Array<keyof typeof Date>) {
610+
assert.equal(changes[key], false, `${test_description}: effect for ${key} was not fired`);
609611
}
610612
};
611613

@@ -615,18 +617,17 @@ test('date fine grained tests', () => {
615617
// @ts-ignore
616618
date[key]();
617619
assert.equal(changes[key], true, `${test_description}: for ${key}`);
620+
changes[key] = false;
618621
});
619622
}
620623
});
621624

622625
flushSync(() => {
623-
reset_change();
626+
expect_all_changes_to_be_false();
624627
changes = {
625628
...changes,
626629
getFullYear: true,
627630
getUTCFullYear: true,
628-
getDate: true,
629-
getUTCDate: true,
630631
getMonth: true,
631632
getUTCMonth: true,
632633
getDay: true,
@@ -637,7 +638,7 @@ test('date fine grained tests', () => {
637638
});
638639

639640
flushSync(() => {
640-
reset_change();
641+
expect_all_changes_to_be_false();
641642
changes = {
642643
...changes,
643644
getDate: true,
@@ -654,11 +655,11 @@ test('date fine grained tests', () => {
654655
getUTCMilliseconds: true
655656
};
656657
test_description = 'changing seconds that will change day/hour/minutes/seconds/milliseconds';
657-
date.setSeconds(60 * 60 * 25 + 1, 10);
658+
date.setSeconds(61 * 60 * 25 + 1, 10);
658659
});
659660

660661
flushSync(() => {
661-
reset_change();
662+
expect_all_changes_to_be_false();
662663
changes = {
663664
...changes,
664665
getMonth: true,

0 commit comments

Comments
 (0)