get rid of class_toggle_effect and style_effect

Author: Rich-Harris

packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js

@@ -74,7 +74,8 @@ function serialize_style_directives(style_directives, element_id, context, is_at
 			directive.value === true
 				? serialize_get_binding({ name: directive.name, type: 'Identifier' }, context.state)
 				: serialize_attribute_value(directive.value, context)[1];
-		const grouped = b.stmt(
+
+		const update = b.stmt(
 			b.call(
 				'$.style',
 				element_id,
@@ -85,17 +86,6 @@ function serialize_style_directives(style_directives, element_id, context, is_at
 				)
 			)
 		);
-		const singular = b.stmt(
-			b.call(
-				'$.style_effect',
-				element_id,
-				b.literal(directive.name),
-				b.arrow([], value),
-				/** @type {import('estree').Expression} */ (
-					directive.modifiers.includes('important') ? b.true : undefined
-				)
-			)
-		);
 
 		const contains_call_expression =
 			Array.isArray(directive.value) &&
@@ -104,11 +94,11 @@ function serialize_style_directives(style_directives, element_id, context, is_at
 			);
 
 		if (!is_attributes_reactive && contains_call_expression) {
-			state.init.push(singular);
+			state.init.push(serialize_update(update));
 		} else if (is_attributes_reactive || directive.metadata.dynamic || contains_call_expression) {
-			state.update.push(grouped);
+			state.update.push(update);
 		} else {
-			state.init.push(grouped);
+			state.init.push(update);
 		}
 	}
 }
@@ -146,18 +136,15 @@ function serialize_class_directives(class_directives, element_id, context, is_at
 	const state = context.state;
 	for (const directive of class_directives) {
 		const value = /** @type {import('estree').Expression} */ (context.visit(directive.expression));
-		const grouped = b.stmt(b.call('$.class_toggle', element_id, b.literal(directive.name), value));
-		const singular = b.stmt(
-			b.call('$.class_toggle_effect', element_id, b.literal(directive.name), b.arrow([], value))
-		);
+		const update = b.stmt(b.call('$.class_toggle', element_id, b.literal(directive.name), value));
 		const contains_call_expression = directive.expression.type === 'CallExpression';
 
 		if (!is_attributes_reactive && contains_call_expression) {
-			state.init.push(singular);
+			state.init.push(serialize_update(update));
 		} else if (is_attributes_reactive || directive.metadata.dynamic || contains_call_expression) {
-			state.update.push(grouped);
+			state.update.push(update);
 		} else {
-			state.init.push(grouped);
+			state.init.push(update);
 		}
 	}
 }

packages/svelte/src/internal/client/dom/elements/class.js

@@ -107,15 +107,3 @@ export function class_toggle(dom, class_name, value) {
 		dom.classList.remove(class_name);
 	}
 }
-
-/**
- * @param {Element} dom
- * @param {string} class_name
- * @param {() => boolean} value
- * @returns {void}
- */
-export function class_toggle_effect(dom, class_name, value) {
-	render_effect(() => {
-		class_toggle(dom, class_name, value());
-	});
-}

packages/svelte/src/internal/client/dom/elements/style.js

@@ -17,17 +17,3 @@ export function style(dom, key, value, important) {
 		style.setProperty(key, value, important ? 'important' : '');
 	}
 }
-
-/**
- * @param {HTMLElement} dom
- * @param {string} key
- * @param {() => string} value
- * @param {boolean} [important]
- * @returns {void}
- */
-export function style_effect(dom, key, value, important) {
-	render_effect(() => {
-		const string = value();
-		style(dom, key, string, important);
-	});
-}