fix: correctly compile $effect.root in svelte modules

trueadm · trueadm · commit 4ce5f37c2484 · 2024-07-05T14:42:21.000+01:00
diff --git a/.changeset/smart-fans-crash.md b/.changeset/smart-fans-crash.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: correctly compile $effect.root in svelte modules
diff --git a/packages/svelte/src/compiler/phases/3-transform/server/transform-server.js b/packages/svelte/src/compiler/phases/3-transform/server/transform-server.js
@@ -411,6 +411,13 @@ const global_visitors = {
 			return b.literal(false);
 		}
 
+		if (rune === '$effect.root') {
+			const args = /** @type {import('estree').Expression[]} */ (
+				node.arguments.map((arg) => context.visit(arg))
+			);
+			return b.call('$.effect_root', ...args);
+		}
+
 		if (rune === '$state.snapshot') {
 			return /** @type {import('estree').Expression} */ (context.visit(node.arguments[0]));
 		}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: correctly compile $effect.root in svelte modules
Original file line number	Diff line number	Diff line change
`@@ -411,6 +411,13 @@ const global_visitors = {`
`411`	`411`	`return b.literal(false);`
`412`	`412`	`}`
`413`	`413`
	`414`	`+ if (rune === '$effect.root') {`
	`415`	`+ const args = /** @type {import('estree').Expression[]} */ (`
	`416`	`+ node.arguments.map((arg) => context.visit(arg))`
	`417`	`+ );`
	`418`	`+ return b.call('$.effect_root', ...args);`
	`419`	`+ }`
	`420`	`+`
`414`	`421`	`if (rune === '$state.snapshot') {`
`415`	`422`	`return /** @type {import('estree').Expression} */ (context.visit(node.arguments[0]));`
`416`	`423`	`}`