address feedback

Author: trueadm

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -584,12 +584,18 @@ export const validation_runes_js = {
 		const callee = node.callee;
 
 		const binding = callee.type === 'Identifier' ? context.state.scope.get(callee.name) : null;
+		const is_module = context.state.ast_type === 'module';
+		// In modules, we allow top-level module scope only, in components, we allow the component scope,
+		// which is function_depth of 1. With the exception of `new class` which is also not allowed at
+		// component scope level either.
+		const allowed_depth = is_module ? 0 : 1;
+
 		if (
-			(callee.type === 'ClassExpression' && context.state.scope.function_depth !== 0) ||
+			(callee.type === 'ClassExpression' && context.state.scope.function_depth > 0) ||
 			(binding !== null &&
 				binding.initial !== null &&
 				binding.initial.type === 'ClassDeclaration' &&
-				binding.scope.function_depth !== 0)
+				binding.scope.function_depth > allowed_depth)
 		) {
 			warn(context.state.analysis.warnings, node, context.path, 'inline-new-class');
 		}

packages/svelte/tests/validator/samples/inline-new-class-2/input.svelte

@@ -1,6 +1,8 @@
 <script>
-	class Foo {
-		foo = $state(0)
+	function bar() {
+		class Foo {
+			foo = $state(0)
+		}
+		const a = new Foo();
 	}
-	const a = new Foo();
 </script>

packages/svelte/tests/validator/samples/inline-new-class-2/warnings.json

@@ -3,12 +3,12 @@
 		"code": "inline-new-class",
 		"message": "Creating inline classes will likely cause performance issues. Instead, declare the class at the module-level and create new instances from the class reference.",
 		"start": {
-			"column": 11,
-			"line": 5
+			"column": 12,
+			"line": 6
 		},
 		"end": {
-			"column": 20,
-			"line": 5
+			"column": 21,
+			"line": 6
 		}
 	}
 ]