Skip to content

Commit 4fd8ce5

Browse files
committed
simplify
1 parent 27d48c6 commit 4fd8ce5

File tree

3 files changed

+22
-32
lines changed

3 files changed

+22
-32
lines changed

packages/svelte/src/internal/client/dom/blocks/html.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function html_to_dom(target, effect, value, svg) {
7979
var child = /** @type {Text | Element | Comment} */ (node.firstChild);
8080
target.before(child);
8181
if (effect !== null) {
82-
push_template_node(effect, child);
82+
push_template_node(child, effect);
8383
}
8484
return child;
8585
}
@@ -95,7 +95,7 @@ function html_to_dom(target, effect, value, svg) {
9595
}
9696

9797
if (effect !== null) {
98-
push_template_node(effect, nodes);
98+
push_template_node(nodes, effect);
9999
}
100100

101101
return nodes;

packages/svelte/src/internal/client/dom/blocks/svelte-element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export function element(anchor, get_tag, is_svg, render_fn) {
133133
swap_block_dom(parent_effect, prev_element, element);
134134
prev_element.remove();
135135
} else if (!hydrating) {
136-
push_template_node(parent_effect, element);
136+
push_template_node(element, parent_effect);
137137
}
138138
});
139139
}

packages/svelte/src/internal/client/dom/template.js

Lines changed: 19 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@ import { effect } from '../reactivity/effects.js';
77
import { is_array } from '../utils.js';
88

99
/**
10-
* @param {import("#client").Effect} effect
1110
* @param {import("#client").TemplateNode | import("#client").TemplateNode[]} dom
11+
* @param {import("#client").Effect} effect
1212
*/
13-
export function push_template_node(effect, dom) {
13+
export function push_template_node(
14+
dom,
15+
effect = /** @type {import('#client').Effect} */ (current_effect)
16+
) {
1417
var current_dom = effect.dom;
1518
if (current_dom === null) {
1619
effect.dom = dom;
@@ -51,10 +54,7 @@ export function template(content, flags) {
5154
return () => {
5255
var effect = /** @type {import('#client').Effect} */ (current_effect);
5356
if (hydrating) {
54-
var hydration_content = push_template_node(
55-
effect,
56-
is_fragment ? hydrate_nodes : hydrate_nodes[0]
57-
);
57+
var hydration_content = push_template_node(is_fragment ? hydrate_nodes : hydrate_nodes[0]);
5858
return /** @type {Node} */ (hydration_content);
5959
}
6060

@@ -64,14 +64,11 @@ export function template(content, flags) {
6464
}
6565
var clone = use_import_node ? document.importNode(node, true) : clone_node(node, true);
6666

67-
if (is_fragment) {
68-
push_template_node(
69-
effect,
70-
/** @type {import('#client').TemplateNode[]} */ ([...clone.childNodes])
71-
);
72-
} else {
73-
push_template_node(effect, /** @type {import('#client').TemplateNode} */ (clone));
74-
}
67+
push_template_node(
68+
is_fragment
69+
? /** @type {import('#client').TemplateNode[]} */ ([...clone.childNodes])
70+
: /** @type {import('#client').TemplateNode} */ (clone)
71+
);
7572

7673
return clone;
7774
};
@@ -117,10 +114,7 @@ export function svg_template(content, flags) {
117114
return () => {
118115
var effect = /** @type {import('#client').Effect} */ (current_effect);
119116
if (hydrating) {
120-
var hydration_content = push_template_node(
121-
effect,
122-
is_fragment ? hydrate_nodes : hydrate_nodes[0]
123-
);
117+
var hydration_content = push_template_node(is_fragment ? hydrate_nodes : hydrate_nodes[0]);
124118
return /** @type {Node} */ (hydration_content);
125119
}
126120

@@ -139,14 +133,11 @@ export function svg_template(content, flags) {
139133

140134
var clone = clone_node(node, true);
141135

142-
if (is_fragment) {
143-
push_template_node(
144-
effect,
145-
/** @type {import('#client').TemplateNode[]} */ ([...clone.childNodes])
146-
);
147-
} else {
148-
push_template_node(effect, /** @type {import('#client').TemplateNode} */ (clone));
149-
}
136+
push_template_node(
137+
is_fragment
138+
? /** @type {import('#client').TemplateNode[]} */ ([...clone.childNodes])
139+
: /** @type {import('#client').TemplateNode} */ (clone)
140+
);
150141

151142
return clone;
152143
};
@@ -213,8 +204,7 @@ function run_scripts(node) {
213204
*/
214205
/*#__NO_SIDE_EFFECTS__*/
215206
export function text(anchor) {
216-
var effect = /** @type {import('#client').Effect} */ (current_effect);
217-
if (!hydrating) return push_template_node(effect, empty());
207+
if (!hydrating) return push_template_node(empty());
218208

219209
var node = hydrate_nodes[0];
220210

@@ -224,7 +214,7 @@ export function text(anchor) {
224214
anchor.before((node = empty()));
225215
}
226216

227-
return push_template_node(effect, node);
217+
return push_template_node(node);
228218
}
229219

230220
export const comment = template('<!>', TEMPLATE_FRAGMENT);

0 commit comments

Comments
 (0)