disallow beforeUpdate/afterUpdate imports in runes mode

Author: Rich-Harris

packages/svelte/src/compiler/errors.js

@@ -200,6 +200,8 @@ const runes = {
 		`${rune} can only be called with ${list(args, 'or')} ${
 			args.length === 1 && args[0] === 1 ? 'argument' : 'arguments'
 		}`,
+	/** @param {string} name */
+	'invalid-runes-mode-import': (name) => `${name} cannot be used in runes mode`,
 	'duplicate-props-rune': () => `Cannot use $props() more than once`
 };
 

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -492,6 +492,20 @@ const validation = {
 			error(node, 'invalid-const-placement');
 		}
 	},
+	ImportDeclaration(node, context) {
+		if (context.state.analysis.runes) {
+			for (const specifier of node.specifiers) {
+				if (specifier.type === 'ImportSpecifier') {
+					if (
+						specifier.imported.name === 'beforeUpdate' ||
+						specifier.imported.name === 'afterUpdate'
+					) {
+						error(specifier, 'invalid-runes-mode-import', specifier.imported.name);
+					}
+				}
+			}
+		}
+	},
 	LetDirective(node, context) {
 		const parent = context.path.at(-1);
 		if (

packages/svelte/tests/compiler-errors/samples/runes-before-after-update/_config.js

@@ -0,0 +1,8 @@
+import { test } from '../../test';
+
+export default test({
+	error: {
+		code: 'invalid-runes-mode-import',
+		message: 'beforeUpdate cannot be used in runes mode'
+	}
+});

packages/svelte/tests/compiler-errors/samples/runes-before-after-update/main.svelte

@@ -0,0 +1,5 @@
+<svelte:options runes />
+
+<script>
+	import { beforeUpdate, afterUpdate } from 'svelte';
+</script>