Skip to content

Commit 6f274ac

Browse files
committed
tweak
1 parent 1d81838 commit 6f274ac

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

packages/svelte/src/compiler/phases/2-analyze/validation.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -969,9 +969,7 @@ function validate_no_const_assignment(node, argument, scope, is_binding) {
969969
function validate_assignment(node, argument, state) {
970970
validate_no_const_assignment(node, argument, state.scope, false);
971971

972-
if (!state.analysis.runes) return;
973-
974-
if (argument.type === 'Identifier') {
972+
if (state.analysis.runes && argument.type === 'Identifier') {
975973
const binding = state.scope.get(argument.name);
976974
if (binding?.kind === 'derived') {
977975
error(node, 'invalid-derived-assignment');
@@ -982,17 +980,17 @@ function validate_assignment(node, argument, state) {
982980
}
983981
}
984982

985-
let obj = /** @type {import('estree').Expression | import('estree').Super} */ (argument);
983+
let object = /** @type {import('estree').Expression | import('estree').Super} */ (argument);
986984

987985
/** @type {import('estree').Expression | import('estree').PrivateIdentifier | null} */
988986
let property = null;
989987

990-
while (obj.type === 'MemberExpression') {
991-
property = obj.property;
992-
obj = obj.object;
988+
while (object.type === 'MemberExpression') {
989+
property = object.property;
990+
object = object.object;
993991
}
994992

995-
if (obj.type === 'ThisExpression' && property?.type === 'PrivateIdentifier') {
993+
if (object.type === 'ThisExpression' && property?.type === 'PrivateIdentifier') {
996994
if (state.private_derived_state.includes(property.name)) {
997995
error(node, 'invalid-derived-assignment');
998996
}

packages/svelte/src/compiler/phases/3-transform/client/transform-client.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -488,10 +488,7 @@ export function client_component(source, analysis, options) {
488488
/** @type {import('estree').Property[]} */
489489
const props_str = [];
490490

491-
for (const [name, binding] of analysis.instance.scope.declarations) {
492-
if ((binding.kind !== 'prop' && binding.kind !== 'bindable_prop') || name.startsWith('$$'))
493-
continue;
494-
491+
for (const [name, binding] of properties) {
495492
const key = binding.prop_alias ?? name;
496493
const prop_def = typeof ce === 'boolean' ? {} : ce.props?.[key] || {};
497494
if (

0 commit comments

Comments
 (0)