remove set_custom_element_data_effect

Author: Rich-Harris

packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js

@@ -496,40 +496,18 @@ function serialize_custom_element_attribute_update_assignment(node_id, attribute
 	const state = context.state;
 	const name = attribute.name; // don't lowercase, as we set the element's property, which might be case sensitive
 	let [contains_call_expression, value] = serialize_attribute_value(attribute.value, context);
-	let grouped_value = value;
 
-	/**
-	 * @param {import('estree').Expression} grouped
-	 * @param {import('estree').Expression} [singular]
-	 */
-	const assign = (grouped, singular) => {
-		if (singular) {
-			return {
-				singular: b.stmt(
-					b.call('$.set_custom_element_data_effect', node_id, b.literal(name), b.thunk(singular))
-				),
-				grouped: b.stmt(b.call('$.set_custom_element_data', node_id, b.literal(name), grouped))
-			};
-		}
-		return {
-			grouped: b.stmt(b.call('$.set_custom_element_data', node_id, b.literal(name), grouped))
-		};
-	};
+	const update = b.stmt(b.call('$.set_custom_element_data', node_id, b.literal(name), value));
 
 	if (attribute.metadata.dynamic) {
-		const id = state.scope.generate(`${node_id.name}_${name}`);
-		// TODO should this use the if condition? what if someone mutates the value passed to the ce?
-		serialize_update_assignment(
-			state,
-			id,
-			undefined,
-			grouped_value,
-			assign(b.id(id), value),
-			contains_call_expression
-		);
+		if (contains_call_expression) {
+			state.init.push(serialize_update(update));
+		} else {
+			state.update.push(update);
+		}
 		return true;
 	} else {
-		state.init.push(assign(grouped_value).grouped);
+		state.init.push(update);
 		return false;
 	}
 }

packages/svelte/src/internal/client/dom/elements/attributes.js

@@ -62,17 +62,6 @@ export function xlink_attr(dom, attribute, value) {
 	dom.setAttributeNS('http://www.w3.org/1999/xlink', attribute, value);
 }
 
-/**
- * @param {any} node
- * @param {string} prop
- * @param {() => any} value
- */
-export function set_custom_element_data_effect(node, prop, value) {
-	render_effect(() => {
-		set_custom_element_data(node, prop, value());
-	});
-}
-
 /**
  * @param {any} node
  * @param {string} prop

packages/svelte/tests/snapshot/samples/dynamic-attributes-casing/_expected/client/main.svelte.js

@@ -15,7 +15,6 @@ export default function Main($$anchor, $$props) {
 	var div = $.first_child(fragment);
 	var svg = $.sibling($.sibling(div, true));
 	var custom_element = $.sibling($.sibling(svg, true));
-	var custom_element_fooBar;
 	var div_1 = $.sibling($.sibling(custom_element, true));
 
 	$.render_effect(() => $.attr(div_1, "foobar", y()));
@@ -26,15 +25,12 @@ export default function Main($$anchor, $$props) {
 
 	var custom_element_1 = $.sibling($.sibling(svg_1, true));
 
-	$.set_custom_element_data_effect(custom_element_1, "fooBar", y);
+	$.render_effect(() => $.set_custom_element_data(custom_element_1, "fooBar", y()));
 
 	$.render_effect(() => {
 		$.attr(div, "foobar", x);
 		$.attr(svg, "viewBox", x);
-
-		if (custom_element_fooBar !== (custom_element_fooBar = x)) {
-			$.set_custom_element_data(custom_element, "fooBar", custom_element_fooBar);
-		}
+		$.set_custom_element_data(custom_element, "fooBar", x);
 	});
 
 	$.close_frag($$anchor, fragment);