Skip to content

Commit 752f872

Browse files
markpsianoMark SianoRich-Harris
authored
fix: memory leak in unmount where document event listeners are not being removed (#12101)
* Fix memory leak in unmount where document event listeners are not being removed * changeset --------- Co-authored-by: Mark Siano <[email protected]> Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]>
1 parent 2814e9e commit 752f872

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.changeset/bright-berries-smell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"svelte": patch
3+
---
4+
5+
fix: remove correct event listener from document

packages/svelte/src/internal/client/render.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ function _mount(Component, { target, anchor, props = {}, events, context, intro
265265
return () => {
266266
for (const event_name of registered_events) {
267267
target.removeEventListener(event_name, bound_event_listener);
268-
document.removeEventListener(event_name, bound_event_listener);
268+
document.removeEventListener(event_name, bound_document_event_listener);
269269
}
270270
root_event_handles.delete(event_handle);
271271
mounted_components.delete(component);

0 commit comments

Comments
 (0)