fix: always assign text.nodeValue (#11944)

* fix: always assign text.nodeValue

* guard

* this seems to work

Author: Rich-Harris

.changeset/twelve-cows-learn.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: always assign text.nodeValue

packages/svelte/src/internal/client/dom/operations.js

@@ -36,7 +36,7 @@ export function init_operations() {
 	element_prototype.__e = undefined;
 
 	// @ts-expect-error
-	Text.prototype.__nodeValue = ' ';
+	Text.prototype.__t = undefined;
 
 	if (DEV) {
 		// @ts-expect-error

packages/svelte/src/internal/client/render.js

@@ -36,22 +36,17 @@ export function set_should_intro(value) {
 }
 
 /**
- * @param {Element} dom
+ * @param {Element} text
  * @param {string} value
  * @returns {void}
  */
-export function set_text(dom, value) {
-	// @ts-expect-error need to add __value to patched prototype
-	const prev_node_value = dom.__nodeValue;
-	const next_node_value = stringify(value);
-	if (hydrating && dom.nodeValue === next_node_value) {
-		// In case of hydration don't reset the nodeValue as it's already correct.
-		// @ts-expect-error need to add __nodeValue to patched prototype
-		dom.__nodeValue = next_node_value;
-	} else if (prev_node_value !== next_node_value) {
-		dom.nodeValue = next_node_value;
-		// @ts-expect-error need to add __className to patched prototype
-		dom.__nodeValue = next_node_value;
+export function set_text(text, value) {
+	// @ts-expect-error
+	const prev = (text.__t ??= text.nodeValue);
+
+	if (prev !== value) {
+		// @ts-expect-error
+		text.nodeValue = text.__t = value;
 	}
 }
 

packages/svelte/tests/runtime-legacy/samples/bindings-coalesced/_config.js

@@ -9,7 +9,7 @@ export default test({
 
 		Object.defineProperty(p.childNodes[0], 'nodeValue', {
 			set(value) {
-				values.push(value);
+				values.push('' + value);
 			}
 		});
 

packages/svelte/tests/runtime-runes/samples/each-whitespace/_config.js

@@ -0,0 +1,6 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+
+export default test({
+	html: `<p>space between</p>`
+});

packages/svelte/tests/runtime-runes/samples/each-whitespace/main.svelte

@@ -0,0 +1,7 @@
+<svelte:options runes />
+
+<p>
+	{#each ['space', ' ', 'between'] as word}
+		{word}
+	{/each}
+</p>