Skip to content

Commit 78a30d9

Browse files
committed
chore: bit of code cleanup
1 parent 2e238ad commit 78a30d9

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

packages/svelte/src/internal/client/runtime.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -379,13 +379,15 @@ function execute_signal_fn(signal) {
379379
// If we have more than 16 elements in the array then use a Set for faster performance
380380
// TODO: evaluate if we should always just use a Set or not here?
381381
const full_current_dependencies_set =
382-
current_dep_length > 16 ? new Set(full_current_dependencies) : null;
382+
current_dep_length > 16 && deps_length - current_dependencies_index > 1
383+
? new Set(full_current_dependencies)
384+
: null;
383385
for (i = current_dependencies_index; i < deps_length; i++) {
384386
const dependency = dependencies[i];
385387
if (
386-
(full_current_dependencies_set !== null &&
387-
!full_current_dependencies_set.has(dependency)) ||
388-
!full_current_dependencies.includes(dependency)
388+
full_current_dependencies_set !== null
389+
? !full_current_dependencies_set.has(dependency)
390+
: !full_current_dependencies.includes(dependency)
389391
) {
390392
remove_consumer(signal, dependency);
391393
}
@@ -1084,7 +1086,7 @@ function mark_subtree_children_inert(signal, inert, visited_blocks) {
10841086
for (i = 0; i < references.length; i++) {
10851087
const reference = references[i];
10861088
if ((reference.f & IS_EFFECT) !== 0) {
1087-
mark_subtree_inert(references[i], inert, visited_blocks);
1089+
mark_subtree_inert(reference, inert, visited_blocks);
10881090
}
10891091
}
10901092
}

packages/svelte/tests/signals/test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ describe('signals', () => {
199199
};
200200
});
201201

202+
// outside of test function so that they are unowned signals
202203
let count = $.source(0);
203204
let calc = $.derived(() => {
204205
if ($.get(count) >= 2) {
@@ -207,7 +208,7 @@ describe('signals', () => {
207208
return $.get(count) * 2;
208209
});
209210

210-
test('effect with derived using new derived every time', () => {
211+
test('effect with derived using unowned derived every time', () => {
211212
const log: Array<number | string> = [];
212213

213214
const effect = $.user_effect(() => {

0 commit comments

Comments
 (0)