call set_signal_status inside execute_effect

Rich-Harris · Rich-Harris · commit 7e97a6c0ce40 · 2024-03-25T18:37:00.000-04:00
diff --git a/packages/svelte/src/internal/client/reactivity/effects.js b/packages/svelte/src/internal/client/reactivity/effects.js
@@ -73,7 +73,6 @@ function create_effect(type, fn, sync, init = true) {
 			try {
 				set_is_flushing_effect(true);
 				execute_effect(effect);
-				set_signal_status(effect, CLEAN);
 				effect.f |= EFFECT_RAN;
 			} finally {
 				set_is_flushing_effect(previously_flushing_effect);
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -384,6 +384,8 @@ export function execute_effect(signal) {
 		return;
 	}
 
+	set_signal_status(signal, CLEAN);
+
 	const previous_effect = current_effect;
 	const previous_component_context = current_component_context;
 
@@ -439,7 +441,6 @@ function flush_queued_effects(effects) {
 
 			if ((signal.f & (DESTROYED | INERT)) === 0) {
 				if (check_dirtiness(signal)) {
-					set_signal_status(signal, CLEAN);
 					execute_effect(signal);
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -384,6 +384,8 @@ export function execute_effect(signal) {`
`384`	`384`	`return;`
`385`	`385`	`}`
`386`	`386`
	`387`	`+ set_signal_status(signal, CLEAN);`
	`388`	`+`
`387`	`389`	`const previous_effect = current_effect;`
`388`	`390`	`const previous_component_context = current_component_context;`
`389`	`391`
`@@ -439,7 +441,6 @@ function flush_queued_effects(effects) {`
`439`	`441`
`440`	`442`	`if ((signal.f & (DESTROYED \| INERT)) === 0) {`
`441`	`443`	`if (check_dirtiness(signal)) {`
`442`		`- set_signal_status(signal, CLEAN);`
`443`	`444`	`execute_effect(signal);`
`444`	`445`	`}`
`445`	`446`	`}`