fix(a11y): do not warn if href value is dynamic (#6110)

thollander · web-flow · commit 842b8412b675 · 2021-04-30T11:55:38.000-04:00
diff --git a/src/compiler/compile/nodes/Attribute.ts b/src/compiler/compile/nodes/Attribute.ts
@@ -96,7 +96,7 @@ export default class Attribute extends Node {
 	}
 
 	get_static_value() {
-		if (this.is_spread || this.dependencies.size > 0) return null;
+		if (!this.is_static) return null;
 
 		return this.is_true
 			? true
diff --git a/test/validator/samples/a11y-anchor-has-content/input.svelte b/test/validator/samples/a11y-anchor-has-content/input.svelte
@@ -1 +1,2 @@
-<a href='/foo'></a>
+<a href='/foo'></a>
+<a href="#{'foo'}">bar</a>

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ export default class Attribute extends Node {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`get_static_value() {`
`99`		`- if (this.is_spread \|\| this.dependencies.size > 0) return null;`
	`99`	`+ if (!this.is_static) return null;`
`100`	`100`
`101`	`101`	`return this.is_true`
`102`	`102`	`? true`