Skip to content

Commit 8a90af5

Browse files
committed
squelch some console spam
1 parent e40e9eb commit 8a90af5

File tree

1 file changed

+19
-3
lines changed
  • packages/svelte/tests/signals

1 file changed

+19
-3
lines changed

packages/svelte/tests/signals/test.ts

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { derived } from '../../src/internal/client/reactivity/deriveds';
1515
import { snapshot } from '../../src/internal/shared/clone.js';
1616
import { SvelteSet } from '../../src/reactivity/set';
1717
import { DESTROYED } from '../../src/internal/client/constants';
18+
import { noop } from 'svelte/internal/client';
1819

1920
/**
2021
* @param runes runes mode
@@ -469,6 +470,9 @@ describe('signals', () => {
469470
test('schedules rerun when writing to signal before reading it', (runes) => {
470471
if (!runes) return () => {};
471472

473+
const error = console.error;
474+
console.error = noop;
475+
472476
const value = state({ count: 0 });
473477
user_effect(() => {
474478
set(value, { count: 0 });
@@ -482,14 +486,19 @@ describe('signals', () => {
482486
} catch (e: any) {
483487
assert.include(e.message, 'effect_update_depth_exceeded');
484488
errored = true;
489+
} finally {
490+
assert.equal(errored, true);
491+
console.error = error;
485492
}
486-
assert.equal(errored, true);
487493
};
488494
});
489495

490496
test('schedules rerun when updating deeply nested value', (runes) => {
491497
if (!runes) return () => {};
492498

499+
const error = console.error;
500+
console.error = noop;
501+
493502
const value = proxy({ a: { b: { c: 0 } } });
494503
user_effect(() => {
495504
value.a.b.c += 1;
@@ -502,14 +511,19 @@ describe('signals', () => {
502511
} catch (e: any) {
503512
assert.include(e.message, 'effect_update_depth_exceeded');
504513
errored = true;
514+
} finally {
515+
assert.equal(errored, true);
516+
console.error = error;
505517
}
506-
assert.equal(errored, true);
507518
};
508519
});
509520

510521
test('schedules rerun when writing to signal before reading it', (runes) => {
511522
if (!runes) return () => {};
512523

524+
const error = console.error;
525+
console.error = noop;
526+
513527
const value = proxy({ arr: [] });
514528
user_effect(() => {
515529
value.arr = [];
@@ -523,8 +537,10 @@ describe('signals', () => {
523537
} catch (e: any) {
524538
assert.include(e.message, 'effect_update_depth_exceeded');
525539
errored = true;
540+
} finally {
541+
assert.equal(errored, true);
542+
console.error = error;
526543
}
527-
assert.equal(errored, true);
528544
};
529545
});
530546

0 commit comments

Comments
 (0)