Skip to content

Commit 95348aa

Browse files
committed
chore: remove isConnected usage
1 parent 9290983 commit 95348aa

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

packages/svelte/src/internal/client/dom/reconciler.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,9 @@ export function remove(current) {
1414
if (is_array(current)) {
1515
for (var i = 0; i < current.length; i++) {
1616
var node = current[i];
17-
if (node.isConnected) {
18-
node.remove();
19-
}
17+
node.remove();
2018
}
21-
} else if (current.isConnected) {
19+
} else {
2220
current.remove();
2321
}
2422
}

packages/svelte/src/internal/client/reactivity/effects.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,12 +246,12 @@ export function destroy_effect(effect) {
246246

247247
effect.teardown?.call(null);
248248

249-
if (effect.dom !== null) {
249+
var parent = effect.parent;
250+
251+
if (effect.dom !== null && (parent === null || (parent.f & DESTROYED) === 0)) {
250252
remove(effect.dom);
251253
}
252254

253-
var parent = effect.parent;
254-
255255
// If the parent doesn't have any children, then skip this work altogether
256256
if (parent !== null && (effect.f & BRANCH_EFFECT) !== 0 && parent.first !== null) {
257257
var previous = effect.prev;

0 commit comments

Comments
 (0)