conflict

Author: trueadm

packages/svelte/src/internal/client/dev/hmr.js

@@ -34,14 +34,22 @@ export function hmr(source) {
 				// when the component is invalidated, replace it without transitions
 				if (ran) set_should_intro(false);
 
+				var descriptors = Object.getOwnPropertyDescriptors(
+					// @ts-expect-error
+					new.target ? new component(anchor, props) : component(anchor, props)
+				)
+
 				// preserve getters/setters
-				Object.defineProperties(
-					instance,
-					Object.getOwnPropertyDescriptors(
-						// @ts-expect-error
-						new.target ? new component(anchor, props) : component(anchor, props)
-					)
-				);
+				for (var desc in descriptors) {
+					debugger
+					if (descriptors[desc].enumerable) {
+						Object.defineProperty(
+							instance,
+							desc,
+							descriptors[desc]
+						);
+					}
+				}
 
 				if (ran) set_should_intro(true);
 			});

packages/svelte/tests/runtime-legacy/samples/component-not-constructor2/_config.js

@@ -1,6 +1,10 @@
 import { test } from '../../test';
 
 export default test({
+	compileOptions: {
+		dev: false,
+	},
+
 	get props() {
 		return { componentName: 'Sub' };
 	},

packages/svelte/tests/runtime-legacy/shared.ts

@@ -138,9 +138,13 @@ export function runtime_suite(runes: boolean) {
 }
 
 async function common_setup(cwd: string, runes: boolean | undefined, config: RuntimeTest) {
+	const force_hmr = process.env.HMR && config.compileOptions?.dev !== false && !config.error;
+
 	const compileOptions: CompileOptions = {
 		generate: 'client',
 		rootDir: cwd,
+		dev: force_hmr ? true : undefined,
+		hmr: force_hmr ? true : undefined,
 		...config.compileOptions,
 		immutable: config.immutable,
 		accessors: 'accessors' in config ? config.accessors : true,

packages/svelte/tests/runtime-runes/samples/bind-this-proxy/_config.js

@@ -2,6 +2,10 @@ import { flushSync } from 'svelte';
 import { test } from '../../test';
 
 export default test({
+	compileOptions: {
+		dev: false,
+	},
+
 	html: `<button>Toggle</button><div>Hello\nworld</div>`,
 
 	async test({ assert, target, logs }) {

packages/svelte/tests/runtime-runes/samples/spread-props/_config.js

@@ -1,6 +1,10 @@
 import { test } from '../../test';
 
 export default test({
+	compileOptions: {
+		dev: false,
+	},
+
 	async test({ assert, target }) {
 		assert.htmlEqual(
 			target.innerHTML,