chore: swap warning with error

Author: paoloricciuti

.changeset/warm-cherries-shake.md

@@ -2,4 +2,4 @@
 "svelte": patch
 ---
 
-feat: warn when snippet shadow a prop
+feat: error when snippet shadow a prop

packages/svelte/messages/compile-errors/template.md

@@ -240,6 +240,10 @@
 
 > snippets do not support rest parameters; use an array instead
 
+## snippet_shadowing_prop
+
+> This snippet is shadowing the prop `%prop%` with the same name
+
 ## style_directive_invalid_modifier
 
 > `style:` directive can only use the `important` modifier

packages/svelte/messages/compile-warnings/template.md

@@ -37,7 +37,3 @@
 ## slot_element_deprecated
 
 > Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead.
-
-## snippet_shadowing_prop
-
-> This snippet is shadowing the prop `%prop%` with the same name

packages/svelte/src/compiler/errors.js

@@ -1374,4 +1374,14 @@ export function unexpected_reserved_word(node, word) {
  */
 export function void_element_invalid_content(node) {
 	e(node, "void_element_invalid_content", "Void elements cannot have children or closing tags");
+}
+
+/**
+ * This snippet is shadowing the prop `%prop%` with the same name
+ * @param {null | number | NodeLike} node
+ * @param {string} prop
+ * @returns {never}
+ */
+export function snippet_shadowing_prop(node, prop) {
+	e(node, "snippet_shadowing_prop", `This snippet is shadowing the prop \`${prop}\` with the same name`);
 }

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -636,7 +636,7 @@ const validation = {
 					attribute.name === node.expression.name
 			)
 		) {
-			w.snippet_shadowing_prop(node, node.expression.name);
+			e.snippet_shadowing_prop(node, node.expression.name);
 		}
 
 		if (node.expression.name !== 'children') return;

packages/svelte/src/compiler/warnings.js

@@ -90,8 +90,7 @@ export const codes = [
 	"component_name_lowercase",
 	"element_invalid_self_closing_tag",
 	"event_directive_deprecated",
-	"slot_element_deprecated",
-	"snippet_shadowing_prop"
+	"slot_element_deprecated"
 ];
 
 /**
@@ -713,13 +712,4 @@ export function event_directive_deprecated(node, name) {
  */
 export function slot_element_deprecated(node) {
 	w(node, "slot_element_deprecated", "Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead.");
-}
-
-/**
- * This snippet is shadowing the prop `%prop%` with the same name
- * @param {null | NodeLike} node
- * @param {string} prop
- */
-export function snippet_shadowing_prop(node, prop) {
-	w(node, "snippet_shadowing_prop", `This snippet is shadowing the prop \`${prop}\` with the same name`);
 }