chore: remove blocks (#10880)

* attach DOM to effects

* null out effect.dom

* remove some block.d references

* another

* drive-by fix

* better comment

* unused arg

* another

* another

* another

* more

* finish renaming stuff

* more

* remove item.d

* remove block.d

* remove effect.block

* remove current_block

* delete delete delete

* rename

* remove some stuff we dont need

* simplify

Author: Rich-Harris

packages/svelte/src/internal/client/dom/blocks/await.js

@@ -9,8 +9,7 @@ import {
 	set_current_reaction
 } from '../../runtime.js';
 import { destroy_effect, pause_effect, render_effect } from '../../reactivity/effects.js';
-import { DESTROYED, INERT } from '../../constants.js';
-import { create_block } from './utils.js';
+import { INERT } from '../../constants.js';
 
 /**
  * @template V
@@ -22,8 +21,6 @@ import { create_block } from './utils.js';
  * @returns {void}
  */
 export function await_block(anchor, get_input, pending_fn, then_fn, catch_fn) {
-	const block = create_block();
-
 	const component_context = current_component_context;
 
 	hydrate_block_anchor(anchor);
@@ -48,7 +45,7 @@ export function await_block(anchor, get_input, pending_fn, then_fn, catch_fn) {
 		set_current_effect(branch);
 		set_current_reaction(branch); // TODO do we need both?
 		set_current_component_context(component_context);
-		var effect = render_effect(() => fn(anchor, value), {}, true);
+		var effect = render_effect(() => fn(anchor, value), true);
 		set_current_component_context(null);
 		set_current_reaction(null);
 		set_current_effect(null);
@@ -60,18 +57,6 @@ export function await_block(anchor, get_input, pending_fn, then_fn, catch_fn) {
 		return effect;
 	}
 
-	/** @param {import('#client').Effect} effect */
-	function pause(effect) {
-		if ((effect.f & DESTROYED) !== 0) return;
-		const block = effect.block;
-
-		pause_effect(effect, () => {
-			// TODO make this unnecessary
-			const dom = block?.d;
-			if (dom) remove(dom);
-		});
-	}
-
 	const branch = render_effect(() => {
 		if (input === (input = get_input())) return;
 
@@ -80,53 +65,53 @@ export function await_block(anchor, get_input, pending_fn, then_fn, catch_fn) {
 
 			if (pending_fn) {
 				if (pending_effect && (pending_effect.f & INERT) === 0) {
-					if (pending_effect.block?.d) remove(pending_effect.block.d);
+					if (pending_effect.dom) remove(pending_effect.dom);
 					destroy_effect(pending_effect);
 				}
 
-				pending_effect = render_effect(() => pending_fn(anchor), {}, true);
+				pending_effect = render_effect(() => pending_fn(anchor), true);
 			}
 
-			if (then_effect) pause(then_effect);
-			if (catch_effect) pause(catch_effect);
+			if (then_effect) pause_effect(then_effect);
+			if (catch_effect) pause_effect(catch_effect);
 
 			promise.then(
 				(value) => {
 					if (promise !== input) return;
-					if (pending_effect) pause(pending_effect);
+					if (pending_effect) pause_effect(pending_effect);
 
 					if (then_fn) {
 						then_effect = create_effect(then_fn, value);
 					}
 				},
 				(error) => {
 					if (promise !== input) return;
-					if (pending_effect) pause(pending_effect);
+					if (pending_effect) pause_effect(pending_effect);
 
 					if (catch_fn) {
 						catch_effect = create_effect(catch_fn, error);
 					}
 				}
 			);
 		} else {
-			if (pending_effect) pause(pending_effect);
-			if (catch_effect) pause(catch_effect);
+			if (pending_effect) pause_effect(pending_effect);
+			if (catch_effect) pause_effect(catch_effect);
 
 			if (then_fn) {
 				if (then_effect) {
-					if (then_effect.block?.d) remove(then_effect.block.d);
+					if (then_effect.dom) remove(then_effect.dom);
 					destroy_effect(then_effect);
 				}
 
-				then_effect = render_effect(() => then_fn(anchor, input), {}, true);
+				then_effect = render_effect(() => then_fn(anchor, input), true);
 			}
 		}
-	}, block);
+	});
 
 	branch.ondestroy = () => {
 		// TODO this sucks, tidy it up
-		if (pending_effect?.block?.d) remove(pending_effect.block.d);
-		if (then_effect?.block?.d) remove(then_effect.block.d);
-		if (catch_effect?.block?.d) remove(catch_effect.block.d);
+		if (pending_effect?.dom) remove(pending_effect.dom);
+		if (then_effect?.dom) remove(then_effect.dom);
+		if (catch_effect?.dom) remove(catch_effect.dom);
 	};
 }