account for foreign namespace

Rich-Harris · Rich-Harris · commit bc8232b9dbce · 2024-04-15T18:00:08.000-04:00
diff --git a/packages/svelte/src/compiler/phases/2-analyze/validation.js b/packages/svelte/src/compiler/phases/2-analyze/validation.js
@@ -570,8 +570,12 @@ const validation = {
 			}
 		}
 
-		const is_self_closing = context.state.analysis.source[node.end - 2] === '/';
-		if (is_self_closing && !VoidElements.includes(node.name) && !SVGElements.includes(node.name)) {
+		if (
+			context.state.analysis.source[node.end - 2] === '/' &&
+			context.state.options.namespace !== 'foreign' &&
+			!VoidElements.includes(node.name) &&
+			!SVGElements.includes(node.name)
+		) {
 			warn(
 				context.state.analysis.warnings,
 				node,

Original file line number	Diff line number	Diff line change
`@@ -570,8 +570,12 @@ const validation = {`
`570`	`570`	`}`
`571`	`571`	`}`
`572`	`572`
`573`		`- const is_self_closing = context.state.analysis.source[node.end - 2] === '/';`
`574`		`- if (is_self_closing && !VoidElements.includes(node.name) && !SVGElements.includes(node.name)) {`
	`573`	`+ if (`
	`574`	`+ context.state.analysis.source[node.end - 2] === '/' &&`
	`575`	`+ context.state.options.namespace !== 'foreign' &&`
	`576`	`+ !VoidElements.includes(node.name) &&`
	`577`	`+ !SVGElements.includes(node.name)`
	`578`	`+ ) {`
`575`	`579`	`warn(`
`576`	`580`	`context.state.analysis.warnings,`
`577`	`581`	`node,`