better approach

trueadm · trueadm · commit cbf3b09bd72f · 2024-10-30T18:59:04.000Z
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -432,12 +432,12 @@ export function update_effect(effect) {
 	}
 
 	try {
-		destroy_effect_deriveds(effect);
 		if ((flags & BLOCK_EFFECT) !== 0) {
 			destroy_block_effect_children(effect);
 		} else {
 			destroy_effect_children(effect);
 		}
+		destroy_effect_deriveds(effect);
 
 		execute_effect_teardown(effect);
 		var teardown = update_reaction(effect);

Original file line number	Diff line number	Diff line change
`@@ -432,12 +432,12 @@ export function update_effect(effect) {`
`432`	`432`	`}`
`433`	`433`
`434`	`434`	`try {`
`435`		`- destroy_effect_deriveds(effect);`
`436`	`435`	`if ((flags & BLOCK_EFFECT) !== 0) {`
`437`	`436`	`destroy_block_effect_children(effect);`
`438`	`437`	`} else {`
`439`	`438`	`destroy_effect_children(effect);`
`440`	`439`	`}`
	`440`	`+ destroy_effect_deriveds(effect);`
`441`	`441`
`442`	`442`	`execute_effect_teardown(effect);`
`443`	`443`	`var teardown = update_reaction(effect);`