Skip to content

Commit dcbb740

Browse files
committed
revert part of #14811. it makes no sense to show the initial value, it just makes things inconsistent with deriveds. personally i find it more confusing anyway
1 parent 7cc7dfa commit dcbb740

File tree

5 files changed

+3
-6
lines changed

5 files changed

+3
-6
lines changed

packages/svelte/src/internal/client/dev/tracing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export let tracing_expressions = null;
2020
* @param {TraceEntry} [entry]
2121
*/
2222
function log_entry(signal, entry) {
23-
const value = signal.trace_need_increase ? signal.trace_v : signal.v;
23+
const value = signal.v;
2424

2525
if (value === UNINITIALIZED) {
2626
return;

packages/svelte/src/internal/client/reactivity/sources.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ export function internal_set(source, value) {
170170

171171
if (active_effect !== null) {
172172
source.trace_need_increase = true;
173-
source.trace_v ??= old_value;
174173
}
175174
}
176175

packages/svelte/src/internal/client/reactivity/types.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export interface Value<V = unknown> extends Signal {
2121
created?: Error | null;
2222
updated?: Error | null;
2323
trace_need_increase?: boolean;
24-
trace_v?: V;
2524
}
2625

2726
export interface Reaction extends Signal {

packages/svelte/src/internal/client/runtime.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ export function update_effect(effect) {
454454
if (dep.trace_need_increase) {
455455
dep.wv = increment_write_version();
456456
dep.trace_need_increase = undefined;
457-
dep.trace_v = undefined;
458457
}
459458
}
460459
}

packages/svelte/tests/runtime-runes/samples/inspect-trace-reassignment/_config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ export default test({
3636
{ log: true },
3737
{ log: '$state', highlighted: true },
3838
{ log: 'count', highlighted: false },
39-
{ log: 1 },
39+
{ log: 2 },
4040
{ log: 'effect' },
4141
{ log: '$state', highlighted: false },
4242
{ log: 'checked', highlighted: false },
4343
{ log: true },
4444
{ log: '$state', highlighted: true },
4545
{ log: 'count', highlighted: false },
46-
{ log: 2 },
46+
{ log: 3 },
4747
{ log: 'effect' },
4848
{ log: '$state', highlighted: false },
4949
{ log: 'checked', highlighted: false },

0 commit comments

Comments
 (0)