Skip to content

Commit df368be

Browse files
committed
chore: better bind_property implementation
1 parent 03945bd commit df368be

File tree

1 file changed

+9
-10
lines changed
  • packages/svelte/src/internal/client/dom/elements/bindings

1 file changed

+9
-10
lines changed

packages/svelte/src/internal/client/dom/elements/bindings/universal.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ export function bind_content_editable(property, element, get_value, update) {
4040
* @returns {void}
4141
*/
4242
export function bind_property(property, event_name, type, element, get_value, update) {
43-
var target_handler = () => {
43+
var handler = () => {
4444
// @ts-ignore
4545
update(element[property]);
4646
};
4747

48-
element.addEventListener(event_name, target_handler);
48+
element.addEventListener(event_name, handler);
4949

5050
if (type === 'set') {
5151
render_effect(() => {
@@ -55,18 +55,17 @@ export function bind_property(property, event_name, type, element, get_value, up
5555
}
5656

5757
if (type === 'get') {
58-
// @ts-ignore
59-
update(element[property]);
58+
handler();
6059
}
6160

62-
render_effect(() => {
63-
// @ts-ignore
64-
if (element === document.body || element === window || element === document) {
61+
// @ts-ignore
62+
if (element === document.body || element === window || element === document) {
63+
render_effect(() => {
6564
return () => {
66-
element.removeEventListener(event_name, target_handler);
65+
element.removeEventListener(event_name, handler);
6766
};
68-
}
69-
});
67+
});
68+
}
7069
}
7170

7271
/**

0 commit comments

Comments
 (0)