revert ast.js changes for now

Author: Rich-Harris

packages/svelte/src/compiler/utils/ast.js

@@ -54,50 +54,47 @@ export function is_event_attribute(attribute) {
 }
 
 /**
- * Extracts all identifiers from a pattern. By default only those which can be newly declared as part of an assignment expression are included.
+ * Extracts all identifiers from a pattern.
  * @param {ESTree.Pattern} param
  * @param {ESTree.Identifier[]} [nodes]
- * @param {boolean} [include_member_expressions] If `true`, will also include member expressions which can be important in a case like `[a, b] = [c, d]`
  * @returns {ESTree.Identifier[]}
  */
-export function extract_identifiers(param, nodes = [], include_member_expressions = false) {
+export function extract_identifiers(param, nodes = []) {
 	switch (param.type) {
 		case 'Identifier':
 			nodes.push(param);
 			break;
 
 		case 'MemberExpression':
-			if (include_member_expressions) {
-				// Only the `a` from `[a.b[c].d]` is of interest to us here
-				const id = object(param);
-				if (id) nodes.push(id);
-			}
+			// Only the `a` from `[a.b[c].d]` is of interest to us here
+			const id = object(param);
+			if (id) nodes.push(id);
 			break;
 
 		case 'ObjectPattern':
 			for (const prop of param.properties) {
 				if (prop.type === 'RestElement') {
-					extract_identifiers(prop.argument, nodes, include_member_expressions);
+					extract_identifiers(prop.argument, nodes);
 				} else {
-					extract_identifiers(prop.value, nodes, include_member_expressions);
+					extract_identifiers(prop.value, nodes);
 				}
 			}
 
 			break;
 
 		case 'ArrayPattern':
 			for (const element of param.elements) {
-				if (element) extract_identifiers(element, nodes, include_member_expressions);
+				if (element) extract_identifiers(element, nodes);
 			}
 
 			break;
 
 		case 'RestElement':
-			extract_identifiers(param.argument, nodes, include_member_expressions);
+			extract_identifiers(param.argument, nodes);
 			break;
 
 		case 'AssignmentPattern':
-			extract_identifiers(param.left, nodes, include_member_expressions);
+			extract_identifiers(param.left, nodes);
 			break;
 	}