fix: ensure disconnected deriveds correctly connect again

trueadm · trueadm · commit e95c94f7cd05 · 2025-01-05T20:08:37.000Z
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -207,6 +207,8 @@ export function check_dirtiness(reaction) {
 				for (i = 0; i < length; i++) {
 					dependency = dependencies[i];
 
+					// We always re-add all reactions (even duplicates) if the derived was
+					// previously disconnected
 					if (is_disconnected || !dependency?.reactions?.includes(reaction)) {
 						(dependency.reactions ??= []).push(reaction);
 					}

Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,8 @@ export function check_dirtiness(reaction) {`
`207`	`207`	`for (i = 0; i < length; i++) {`
`208`	`208`	`dependency = dependencies[i];`
`209`	`209`
	`210`	`+ // We always re-add all reactions (even duplicates) if the derived was`
	`211`	`+ // previously disconnected`
`210`	`212`	`if (is_disconnected \|\| !dependency?.reactions?.includes(reaction)) {`
`211`	`213`	`(dependency.reactions ??= []).push(reaction);`
`212`	`214`	`}`