address feedback

Author: trueadm

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -521,8 +521,8 @@ function validate_call_expression(node, scope, path) {
 	}
 
 	if (rune === '$effect.root') {
-		if (node.arguments.length < 1 || node.arguments.length > 2) {
-			error(node, 'invalid-rune-args-length', '$effect.root', [1, 2]);
+		if (node.arguments.length !== 1) {
+			error(node, 'invalid-rune-args-length', '$effect.root', [1]);
 		}
 	}
 }

packages/svelte/src/internal/client/runtime.js

@@ -1186,14 +1186,10 @@ export function user_effect(init) {
 
 /**
  * @param {() => void | (() => void)} init
- * @param {() => void} [on_parent_cleanup]
  * @returns {() => void}
  */
-export function user_root_effect(init, on_parent_cleanup) {
+export function user_root_effect(init) {
 	const effect = managed_render_effect(init);
-	if (current_effect !== null && typeof on_parent_cleanup === 'function') {
-		push_destroy_fn(current_effect, on_parent_cleanup);
-	}
 	return () => {
 		destroy_signal(effect);
 	};

packages/svelte/src/main/ambient.d.ts

@@ -117,7 +117,7 @@ declare namespace $effect {
 	 *
 	 * https://svelte-5-preview.vercel.app/docs/runes#$effect-root
 	 */
-	export function root(fn: () => void | (() => void), fn2?: () => void): () => void;
+	export function root(fn: () => void | (() => void)): () => void;
 }
 
 /**

packages/svelte/tests/runtime-runes/samples/effect-root/main.svelte

@@ -13,10 +13,12 @@
 			return () => {
 				log.push('cleanup 2')	;
 			}
-		}, () => {
+		});
+
+		return () => {
 			log.push('cleanup 1');
 			nested_cleanup();
-		});
+		}
 	});
 </script>
 

sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md

@@ -207,23 +207,6 @@ nested effects that you want to manually control. This rune also allows for crea
 </script>
 ```
 
-If the `$effect.root` was created within within another active effect (such as during component initialisation) then it might
-be desirable to know when that active effect gets disposed and cleaned up. `$effect.root` takes an optional second arugment,
-which is a function callback for when this happens in case. This allows you to cleanup the effect root too if needed.
-
-```svelte
-<script>
-	let count = $state(0);
-
-	const cleanup = $effect.root(() => {
-		// ...
-	}, () => {
-		console.log('parent effect is cleaned up');
-		cleanup();
-	});
-</script>
-```
-
 ## `$props`
 
 To declare component props, use the `$props` rune: