Skip to content

Commit 158a6d5

Browse files
bluwydominikg
andauthored
Fix optional parameter types (#797)
* Fix optional parameter types * fix: ensure generated types match eslint and prettier * refactor: instead of formatting generated types, ignore them in eslint --------- Co-authored-by: dominikg <[email protected]>
1 parent cf1ef58 commit 158a6d5

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

.changeset/orange-dryers-hear.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/vite-plugin-svelte': patch
3+
---
4+
5+
Fix optional parameter types

.eslintrc.cjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,5 +190,6 @@ module.exports = {
190190
'no-unused-vars': 'off'
191191
}
192192
}
193-
]
193+
],
194+
ignorePatterns: ['packages/*/types/index.d.ts', 'packages/*/types/index.d.ts.map']
194195
};

packages/vite-plugin-svelte/src/preprocess.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const supportedScriptLangs = ['ts'];
1010
export const lang_sep = '.vite-preprocess';
1111

1212
/**
13-
* @param {import('./public.d.ts').VitePreprocessOptions} opts
13+
* @param {import('./public.d.ts').VitePreprocessOptions} [opts]
1414
* @returns {import('svelte/compiler').PreprocessorGroup}
1515
*/
1616
export function vitePreprocess(opts) {

packages/vite-plugin-svelte/src/utils/load-svelte-config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ async function dynamicImportDefault(filePath, timestamp) {
2525
}
2626

2727
/**
28-
* @param {import('vite').UserConfig} viteConfig
29-
* @param {Partial<import('../public.d.ts').Options>} inlineOptions
28+
* @param {import('vite').UserConfig} [viteConfig]
29+
* @param {Partial<import('../public.d.ts').Options>} [inlineOptions]
3030
* @returns {Promise<Partial<import('../public.d.ts').SvelteConfig> | undefined>}
3131
*/
3232
export async function loadSvelteConfig(viteConfig, inlineOptions) {

packages/vite-plugin-svelte/types/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ declare module '@sveltejs/vite-plugin-svelte' {
190190
style?: boolean | InlineConfig | ResolvedConfig;
191191
}
192192
export function svelte(inlineOptions?: Partial<Options> | undefined): import('vite').Plugin[];
193-
export function vitePreprocess(opts: VitePreprocessOptions): import('svelte/compiler').PreprocessorGroup;
194-
export function loadSvelteConfig(viteConfig: import('vite').UserConfig, inlineOptions: Partial<Options>): Promise<Partial<SvelteConfig> | undefined>;
193+
export function vitePreprocess(opts?: VitePreprocessOptions | undefined): import('svelte/compiler').PreprocessorGroup;
194+
export function loadSvelteConfig(viteConfig?: import("vite").UserConfig | undefined, inlineOptions?: Partial<Options> | undefined): Promise<Partial<SvelteConfig> | undefined>;
195195
}
196196

197197
//# sourceMappingURL=index.d.ts.map

0 commit comments

Comments
 (0)