Skip to content

Commit 0242f91

Browse files
trungdq88swengorschewski
authored andcommitted
ESLint 4 (#2735)
* Update eslint-loader 1.7.1 -> 1.9.0 * Add eslintPath option * Update eslint 3.19.0 -> 4.1.1 * Update peer dependencies * Move eslintPath config to outside @remove-on-eject
1 parent 798a4d4 commit 0242f91

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

packages/eslint-config-react-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
],
1313
"peerDependencies": {
1414
"babel-eslint": "^7.2.3",
15-
"eslint": "^3.19.0",
15+
"eslint": "^4.1.1",
1616
"eslint-plugin-flowtype": "^2.33.0",
1717
"eslint-plugin-import": "^2.2.0",
1818
"eslint-plugin-jsx-a11y": "^5.0.3",

packages/react-scripts/config/webpack.config.dev.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,8 @@ module.exports = {
163163
{
164164
exclude: [
165165
/\.html$/,
166-
// We have to write /\.(js|jsx)(\?.*)?$/ rather than just /\.(js|jsx)$/
167-
// because you might change the hot reloading server from the custom one
168-
// to Webpack's built-in webpack-dev-server/client?/, which would not
169-
// get properly excluded by /\.(js|jsx)$/ because of the query string.
170-
// Webpack 2 fixes this, but for now we include this hack.
171-
// https://github.com/facebookincubator/create-react-app/issues/1713
172-
/\.(js|jsx)(\?.*)?$/,
173-
/\.(ts|tsx)(\?.*)?$/,
166+
/\.(js|jsx)$/,
167+
/\.(ts|tsx)$/,
174168
/\.css$/,
175169
/\.json$/,
176170
/\.bmp$/,
@@ -241,7 +235,7 @@ module.exports = {
241235
],
242236
},
243237
// ** STOP ** Are you adding a new loader?
244-
// Remember to add the new extension(s) to the "url" loader exclusion list.
238+
// Remember to add the new extension(s) to the "file" loader exclusion list.
245239
],
246240
},
247241
plugins: [

0 commit comments

Comments
 (0)