Skip to content

Commit 5f5dc1e

Browse files
committed
Rename onRequestCompleted to onConnectionIdle
1 parent efa86b5 commit 5f5dc1e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
6262
private let eventLoop: EventLoop
6363
private let connectionIdLoggerMetadata: Logger.MetadataValue
6464

65-
var onRequestCompleted: () -> Void = {}
65+
var onConnectionIdle: () -> Void = {}
6666
init(eventLoop: EventLoop, backgroundLogger: Logger, connectionIdLoggerMetadata: Logger.MetadataValue) {
6767
self.eventLoop = eventLoop
6868
self.backgroundLogger = backgroundLogger
@@ -275,7 +275,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
275275
if shouldClose {
276276
context.close(promise: nil)
277277
} else {
278-
self.onRequestCompleted()
278+
self.onConnectionIdle()
279279
}
280280

281281
oldRequest.succeedRequest(buffer)
@@ -287,7 +287,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
287287

288288
context.writeAndFlush(self.wrapOutboundOut(.end(nil)), promise: writePromise)
289289
case .informConnectionIsIdle:
290-
self.onRequestCompleted()
290+
self.onConnectionIdle()
291291
oldRequest.succeedRequest(buffer)
292292
}
293293

@@ -304,7 +304,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
304304
oldRequest.fail(error)
305305

306306
case .informConnectionIsIdle:
307-
self.onRequestCompleted()
307+
self.onConnectionIdle()
308308
oldRequest.fail(error)
309309

310310
case .failWritePromise(let writePromise):

Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1Connection.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ final class HTTP1Connection {
137137
backgroundLogger: logger,
138138
connectionIdLoggerMetadata: "\(self.id)"
139139
)
140-
channelHandler.onRequestCompleted = {
140+
channelHandler.onConnectionIdle = {
141141
self.taskCompleted()
142142
}
143143

0 commit comments

Comments
 (0)