make metrics collection independed from metrics creation #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows metrics collection to be concurrent to metrics creation.
SwiftPrometheus' metrics types are already thread-safe, there's no need in holding a global lock while calling
.collecton every single metric.Checklist
Motivation and Context
Currently metrics collection is done under a global lock and it's stopping new metrics from being created in parallel. Allowing this to happen in parallel will reduce the impact metrics framework is having on the running system.
Description
PrometheusClient.collectnow only holds global lock to get a list on metrics in a thread safe manner.metric.collecton individual metric is called without a global lock and relying on corresponding metric type to be thread safe.