Skip to content

Commit 0083fd8

Browse files
author
git apple-llvm automerger
committed
Merge commit '03bfc1f7bae5' from apple/stable/20200714 into swift/main
2 parents cf1d8e1 + 03bfc1f commit 0083fd8

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lldb/source/Utility/TildeExpressionResolver.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,19 @@ bool StandardTildeExpressionResolver::ResolvePartial(StringRef Expr,
7575

7676
bool TildeExpressionResolver::ResolveFullPath(
7777
StringRef Expr, llvm::SmallVectorImpl<char> &Output) {
78-
Output.clear();
7978
if (!Expr.startswith("~")) {
80-
Output.append(Expr.begin(), Expr.end());
79+
Output.assign(Expr.begin(), Expr.end());
8180
return false;
8281
}
8382

8483
namespace path = llvm::sys::path;
8584
StringRef Left =
8685
Expr.take_until([](char c) { return path::is_separator(c); });
8786

88-
if (!ResolveExact(Left, Output))
87+
if (!ResolveExact(Left, Output)) {
88+
Output.assign(Expr.begin(), Expr.end());
8989
return false;
90+
}
9091

9192
Output.append(Expr.begin() + Left.size(), Expr.end());
9293
return true;

lldb/unittests/Utility/TildeExpressionResolverTest.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ TEST(TildeExpressionResolver, ResolveFullPath) {
3131
EXPECT_EQ("/lars", Result);
3232

3333
ASSERT_FALSE(Resolver.ResolveFullPath("~Jaso", Result));
34+
EXPECT_EQ("~Jaso", Result);
3435
ASSERT_FALSE(Resolver.ResolveFullPath("", Result));
36+
EXPECT_EQ("", Result);
3537
ASSERT_FALSE(Resolver.ResolveFullPath("Jason", Result));
38+
EXPECT_EQ("Jason", Result);
3639
}

0 commit comments

Comments
 (0)