Skip to content

Commit 039b28e

Browse files
committed
[LLDB] Fix TestDataFormatterSynthVal.py for AArch64/Windows
Since 44363f2 various tests have started passing but introduced a expression evaluation failure in TestDataFormatterSynthVal.py. This patch marks the expression evaluation part as skipped while rest of the test passes. This patch aslo introduces a new helper isAArch64Windows in lldbtest.py.
1 parent cd3ff25 commit 039b28e

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

lldb/packages/Python/lldbsuite/test/lldbtest.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,6 +1252,13 @@ def isAArch64PAuth(self):
12521252
return True
12531253
return self.isAArch64() and "paca" in self.getCPUInfo()
12541254

1255+
def isAArch64Windows(self):
1256+
"""Returns true if the architecture is AArch64 and platform windows."""
1257+
if self.getPlatform() == 'windows':
1258+
arch = self.getArchitecture().lower()
1259+
return arch in ["aarch64", "arm64", "arm64e"]
1260+
return False
1261+
12551262
def getArchitecture(self):
12561263
"""Returns the architecture in effect the test suite is running with."""
12571264
module = builder_module()

lldb/test/API/functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,10 @@ def cleanup():
9696

9797
# check that an aptly defined synthetic provider does not affect
9898
# one-lining
99-
self.expect(
100-
"expression struct Struct { myInt theInt{12}; }; Struct()",
101-
substrs=['(theInt = 12)'])
99+
if self.isAArch64Windows():
100+
self.expect(
101+
"expression struct Struct { myInt theInt{12}; }; Struct()",
102+
substrs=['(theInt = 12)'])
102103

103104
# check that we can use a synthetic value in a summary
104105
self.runCmd("type summary add hasAnInt -s ${var.theInt}")

0 commit comments

Comments
 (0)