Skip to content

Commit 03c61e6

Browse files
Merge pull request #8054 from adrian-prantl/reenable-objcconflicttest
Reenable objcconflicttest
2 parents c4bbdfb + cff1866 commit 03c61e6

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,12 @@ SwiftLanguageRuntimeImpl::GetNumChildren(CompilerType type,
609609
root, {Kind::TypeMangling, Kind::Type, Kind::BuiltinTypeName});
610610
if (builtin_type)
611611
return 0;
612+
LLDB_LOG(GetLog(LLDBLog::Types),
613+
"{0}: unrecognized builtin type info or this is a Clang type with "
614+
"DWARF debug info",
615+
type.GetMangledTypeName());
616+
return {};
617+
612618
}
613619
// Structs and Tuples.
614620
if (auto *rti = llvm::dyn_cast<swift::reflection::RecordTypeInfo>(ti)) {

lldb/test/API/lang/swift/clangimporter/objcmain_conflicting_dylibs_bridging_headers/TestSwiftObjCMainConflictingDylibsBridgingHeader.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ def test(self):
4040
'break here', lldb.SBFileSpec('Foo.swift'))
4141
process.Continue()
4242
self.expect("fr var foo", "expected result", substrs=["23"])
43+
precise = self.dbg.GetSetting('symbols.swift-precise-compiler-invocation').GetBooleanValue()
44+
if not precise:
45+
return
4346
# FIXME: This should work with precise compiler invocations.
44-
#self.expect("expression foo", "expected result", substrs=["$R3", "23"])
45-
#self.expect("expression $R3", "expected result", substrs=["23"])
46-
#self.expect("expression $R4", "expected result", substrs=["23"])
47+
self.expect("expression foo", "expected result", substrs=["$R3", "23"])
48+
self.expect("expression $R3", "expected result", substrs=["23"])
49+
self.expect("expression $R4", "expected result", substrs=["23"])

lldb/test/API/lang/swift/clangimporter/objcmain_conflicting_dylibs_bridging_headers/dylib.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ DYLIB_ONLY := YES
22
DYLIB_NAME := $(BASENAME)
33
DYLIB_SWIFT_SOURCES := $(DYLIB_NAME).swift
44
SWIFT_BRIDGING_HEADER := $(DYLIB_NAME)/$(DYLIB_NAME)-Bridging.h
5-
SWIFT_PRECOMPILE_BRIDGING_HEADER := NO
5+
SWIFT_PRECOMPILE_BRIDGING_HEADER := YES
66
SWIFT_OBJC_HEADER = $(DYLIB_NAME)-Swift.h
77
SWIFT_OBJC_INTEROP := 1
88
SWIFTFLAGS_EXTRAS = -Xcc -I$(SRCDIR)

0 commit comments

Comments
 (0)