Skip to content

Commit 0b4c4c0

Browse files
committed
[lldb] Remove duplicate DoPlanExplainsStop
`ThreadPlanStepOverRange::DoPlanExplainsStop` was moved to `ThreadPlanStepRange::DoPlanExplansStop` in 3dcce7c. This resulted in a merge conflict, which renamed this method instead of removing it.
1 parent 75224d0 commit 0b4c4c0

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

lldb/source/Target/ThreadPlanStepOverRange.cpp

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -334,37 +334,6 @@ bool ThreadPlanStepOverRange::ShouldStop(Event *event_ptr) {
334334
return false;
335335
}
336336

337-
bool ThreadPlanStepRange::DoPlanExplainsStop(Event *event_ptr) {
338-
// For crashes, breakpoint hits, signals, etc,cd let the base plan (or some
339-
// plan above us) handle the stop. That way the user can see the stop, step
340-
// around, and then when they are done, continue and have their step
341-
// complete. The exception is if we've hit our "run to next branch"
342-
// breakpoint. Note, unlike the step in range plan, we don't mark ourselves
343-
// complete if we hit an unexplained breakpoint/crash.
344-
345-
Log *log = GetLog(LLDBLog::Step);
346-
StopInfoSP stop_info_sp = GetPrivateStopInfo();
347-
bool return_value;
348-
349-
if (stop_info_sp) {
350-
StopReason reason = stop_info_sp->GetStopReason();
351-
352-
if (reason == eStopReasonTrace) {
353-
return_value = true;
354-
} else if (reason == eStopReasonBreakpoint) {
355-
return_value = NextRangeBreakpointExplainsStop(stop_info_sp);
356-
} else {
357-
if (log)
358-
log->PutCString("ThreadPlanStepOverRange got asked if it explains the "
359-
"stop for some reason other than step.");
360-
return_value = false;
361-
}
362-
} else
363-
return_value = true;
364-
365-
return return_value;
366-
}
367-
368337
bool ThreadPlanStepOverRange::DoWillResume(lldb::StateType resume_state,
369338
bool current_plan) {
370339
if (resume_state != eStateSuspended && m_first_resume) {

0 commit comments

Comments
 (0)