Skip to content

Commit 0b7f927

Browse files
committed
[lldb] Pass important options to dsymForUUID (llvm#72669)
On macOS, we usually use the DebugSymbols framework to find dSYMs, but we have a few places (including crashlog.py) that calls out directly to dsymForUUID. Currently, this invocation is missing two important options: * `--ignoreNegativeCache`: Poor network connectivity or lack of VPN can lead to a negative cache hit. Avoiding those issues is worth the penalty of skipping these caches. * `--copyExecutable`: Ensure we copy the executable as it might not be available at its original location. rdar://118480731 (cherry picked from commit ec6a34e)
1 parent f9981c2 commit 0b7f927

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lldb/examples/python/crashlog.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,11 @@ def locate_module_and_debug_symbols(self):
356356
# Keep track of unresolved source paths.
357357
unavailable_source_paths = set()
358358
if os.path.exists(self.dsymForUUIDBinary):
359-
dsym_for_uuid_command = "%s %s" % (self.dsymForUUIDBinary, uuid_str)
359+
dsym_for_uuid_command = (
360+
"{} --copyExecutable --ignoreNegativeCache {}".format(
361+
self.dsymForUUIDBinary, uuid_str
362+
)
363+
)
360364
s = subprocess.check_output(dsym_for_uuid_command, shell=True)
361365
if s:
362366
try:

0 commit comments

Comments
 (0)