Skip to content

Commit 0db9481

Browse files
committed
[NFC] Remove FIXMEs about calling LLVMContext::yield()
Nobody has complained about this, and the documentation for LLVMContext::yield() states that LLVM is allowed to never call it. Reviewed By: asbirlea Differential Revision: https://reviews.llvm.org/D110008
1 parent 843390c commit 0db9481

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

llvm/include/llvm/IR/PassManager.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -536,12 +536,6 @@ class PassManager : public PassInfoMixin<
536536
// Finally, intersect the preserved analyses to compute the aggregate
537537
// preserved set for this pass manager.
538538
PA.intersect(std::move(PassPA));
539-
540-
// FIXME: Historically, the pass managers all called the LLVM context's
541-
// yield function here. We don't have a generic way to acquire the
542-
// context and it isn't yet clear what the right pattern is for yielding
543-
// in the new pass manager so it is currently omitted.
544-
//IR.getContext().yield();
545539
}
546540

547541
// Invalidation was handled after each pass in the above loop for the

llvm/lib/Analysis/CGSCCPassManager.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,6 @@ PassManager<LazyCallGraph::SCC, CGSCCAnalysisManager, LazyCallGraph &,
119119
// Finally, we intersect the final preserved analyses to compute the
120120
// aggregate preserved set for this pass manager.
121121
PA.intersect(std::move(PassPA));
122-
123-
// FIXME: Historically, the pass managers all called the LLVM context's
124-
// yield function here. We don't have a generic way to acquire the
125-
// context and it isn't yet clear what the right pattern is for yielding
126-
// in the new pass manager so it is currently omitted.
127-
// ...getContext().yield();
128122
}
129123

130124
// Before we mark all of *this* SCC's analyses as preserved below, intersect

llvm/lib/Transforms/Scalar/LoopPassManager.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,6 @@ LoopPassManager::runWithLoopNestPasses(Loop &L, LoopAnalysisManager &AM,
124124
// notify the updater, otherwise U.ParentL might gets outdated and triggers
125125
// assertion failures in addSiblingLoops and addChildLoops.
126126
U.setParentLoop(L.getParentLoop());
127-
128-
// FIXME: Historically, the pass managers all called the LLVM context's
129-
// yield function here. We don't have a generic way to acquire the
130-
// context and it isn't yet clear what the right pattern is for yielding
131-
// in the new pass manager so it is currently omitted.
132-
// ...getContext().yield();
133127
}
134128
return PA;
135129
}
@@ -173,12 +167,6 @@ LoopPassManager::runWithoutLoopNestPasses(Loop &L, LoopAnalysisManager &AM,
173167
// notify the updater, otherwise U.ParentL might gets outdated and triggers
174168
// assertion failures in addSiblingLoops and addChildLoops.
175169
U.setParentLoop(L.getParentLoop());
176-
177-
// FIXME: Historically, the pass managers all called the LLVM context's
178-
// yield function here. We don't have a generic way to acquire the
179-
// context and it isn't yet clear what the right pattern is for yielding
180-
// in the new pass manager so it is currently omitted.
181-
// ...getContext().yield();
182170
}
183171
return PA;
184172
}

0 commit comments

Comments
 (0)