Skip to content

Commit 0e5d0cc

Browse files
committed
Make testcase more robust
1 parent 3c2f185 commit 0e5d0cc

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

lldb/test/API/lang/swift/dwarfimporter/C/TestSwiftDWARFImporterC.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ def build(self):
4040
# This test needs a working Remote Mirrors implementation.
4141
@skipIf(oslist=['windows'])
4242
def test_dwarf_importer(self):
43-
lldb.SBDebugger.MemoryPressureDetected()
44-
self.runCmd("settings set symbols.use-swift-dwarfimporter true")
4543
self.build()
4644
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
4745
self, 'break here', lldb.SBFileSpec('main.swift'))
@@ -63,17 +61,12 @@ def test_dwarf_importer(self):
6361
# substrs=["(DoubleLongUnion)", "long_val = 42"])
6462
self.expect("target variable fromSubmodule",
6563
substrs=["(FromSubmodule)", "x = 1", "y = 2", "z = 3"])
66-
process.Clear()
67-
target.Clear()
68-
lldb.SBDebugger.MemoryPressureDetected()
6964

7065
@skipIf(archs=['ppc64le'], bugnumber='SR-10214')
7166
@swiftTest
7267
# This test needs a working Remote Mirrors implementation.
7368
@skipIf(oslist=['windows'])
7469
def test_dwarf_importer_exprs(self):
75-
lldb.SBDebugger.MemoryPressureDetected()
76-
self.runCmd("settings set symbols.use-swift-dwarfimporter true")
7770
self.build()
7871
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
7972
self, 'break here', lldb.SBFileSpec('main.swift'))
@@ -95,15 +88,12 @@ def test_dwarf_importer_exprs(self):
9588
self.expect("expr union", substrs=["(DoubleLongUnion)", "long_val = 42"])
9689
self.expect("expr fromSubmodule",
9790
substrs=["(FromSubmodule)", "x = 1", "y = 2", "z = 3"])
98-
process.Clear()
99-
target.Clear()
100-
lldb.SBDebugger.MemoryPressureDetected()
10191

10292
@skipIf(archs=['ppc64le'], bugnumber='SR-10214')
10393
@swiftTest
94+
@skipIf(setting=('symbols.use-swift-clangimporter', 'false'))
10495
def test_negative(self):
10596
lldb.SBDebugger.MemoryPressureDetected()
106-
self.runCmd("log enable lldb types")
10797
self.runCmd("settings set symbols.use-swift-dwarfimporter false")
10898
self.build()
10999
log = self.getBuildArtifact("types.log")
@@ -114,9 +104,7 @@ def test_negative(self):
114104
# target.FindFirstGlobalVariable("point"),
115105
# typename="Point", num_children=2)
116106
# This can't be resolved.
117-
lldbutil.check_variable(self,
118-
target.FindFirstGlobalVariable("swiftStructCMember"),
119-
num_children=0)
107+
self.expect("expr swiftStructCMember", error=True)
120108

121109
found = False
122110
import io

0 commit comments

Comments
 (0)