llvm-reduce: Use takeName when moving arguments in operands-to-args (llvm#133851)

arsenm · web-flow · commit 14c509864057 · 2025-04-01T14:48:14.000+07:00
diff --git a/llvm/tools/llvm-reduce/deltas/ReduceOperandsToArgs.cpp b/llvm/tools/llvm-reduce/deltas/ReduceOperandsToArgs.cpp
@@ -155,8 +155,8 @@ static void substituteOperandWithArgument(Function *OldF,
     Argument &OldArg = std::get<0>(Z);
     Argument &NewArg = std::get<1>(Z);
 
-    NewArg.setName(OldArg.getName()); // Copy the name over...
-    VMap[&OldArg] = &NewArg;          // Add mapping to VMap
+    NewArg.takeName(&OldArg); // Copy the name over...
+    VMap[&OldArg] = &NewArg;  // Add mapping to VMap
   }
 
   LLVMContext &Ctx = OldF->getContext();

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,8 @@ static void substituteOperandWithArgument(Function *OldF,`
`155`	`155`	`Argument &OldArg = std::get<0>(Z);`
`156`	`156`	`Argument &NewArg = std::get<1>(Z);`
`157`	`157`
`158`		`- NewArg.setName(OldArg.getName()); // Copy the name over...`
`159`		`- VMap[&OldArg] = &NewArg; // Add mapping to VMap`
	`158`	`+ NewArg.takeName(&OldArg); // Copy the name over...`
	`159`	`+ VMap[&OldArg] = &NewArg; // Add mapping to VMap`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`LLVMContext &Ctx = OldF->getContext();`