Merge pull request #9554 from swiftlang/egorzhdan/20240723-class-template-packs

egorzhdan · web-flow · commit 14e578fd7611 · 2024-11-08T20:53:25.000Z
🍒[Clang] Dispatch default overloads of `TemplateArgumentVisitor` to the implementation
diff --git a/clang/include/clang/AST/TemplateArgumentVisitor.h b/clang/include/clang/AST/TemplateArgumentVisitor.h
@@ -52,7 +52,8 @@ class Base {
 #define VISIT_METHOD(CATEGORY)                                                 \
   RetTy Visit##CATEGORY##TemplateArgument(REF(TemplateArgument) TA,            \
                                           ParamTys... P) {                     \
-    return VisitTemplateArgument(TA, std::forward<ParamTys>(P)...);            \
+    return static_cast<ImplClass *>(this)->VisitTemplateArgument(              \
+        TA, std::forward<ParamTys>(P)...);                                     \
   }
 
   VISIT_METHOD(Null);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ class Base {`
`52`	`52`	`#define VISIT_METHOD(CATEGORY) \`
`53`	`53`	`RetTy Visit##CATEGORY##TemplateArgument(REF(TemplateArgument) TA, \`
`54`	`54`	`ParamTys... P) { \`
`55`		`- return VisitTemplateArgument(TA, std::forward<ParamTys>(P)...); \`
	`55`	`+ return static_cast<ImplClass *>(this)->VisitTemplateArgument( \`
	`56`	`+ TA, std::forward<ParamTys>(P)...); \`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`VISIT_METHOD(Null);`