Fix out-of-bounds memory access

Author: adrian-prantl

lldb/test/API/lang/swift/deployment_target/dlopen_module.m

@@ -1,18 +1,18 @@
 #include <Foundation/Foundation.h>
 #include <dlfcn.h>
 #include <libgen.h>
+#include <limits.h>
 
 @protocol FooProtocol
-+ (void)f;
+- (void)f;
 @end
 
 int main(int argc, const char **argv) {
-  char dylib[4096];
-  strlcpy(dylib, dirname(argv[0]), 4096);
-  strlcat(dylib, "/libNewerTarget.dylib", 4096);
+  char dylib[PATH_MAX];
+  strlcpy(dylib, dirname(argv[0]), PATH_MAX);
+  strlcat(dylib, "/libNewerTarget.dylib", PATH_MAX);
   dlopen(dylib, RTLD_LAZY);
   Class<FooProtocol> fooClass = NSClassFromString(@"NewerTarget.Foo");
   [[[fooClass alloc] init] f];
   return 0;
 }
-

lldb/test/API/lang/swift/late_dylib_clangdeps/loader.c

@@ -1,10 +1,13 @@
 #include <dlfcn.h>
+#include <libgen.h>
+#include <limits.h>
 #include <stdio.h>
 #include <string.h>
-#include <libgen.h>
 
 int main(int argc, const char **argv) {
-  char *dylib_name = strcat(dirname(argv[0]),"/dylib.dylib");
+  char dylib_name[PATH_MAX];
+  strlcpy(dylib_name, dirname(argv[0]), PATH_MAX);
+  strlcat(dylib_name, "/dylib.dylib", PATH_MAX);
   void *dylib = dlopen(dylib_name, RTLD_NOW);
   void (*f)() = dlsym(dylib, "f");
   f();

lldb/test/API/lang/swift/unit-tests/xctest.c

@@ -11,13 +11,15 @@
 //===----------------------------------------------------------------------===//
 
 #include <dlfcn.h>
+#include <libgen.h>
+#include <limits.h>
 #include <stdio.h>
 #include <string.h>
-#include <libgen.h>
 
-int main(int argc, const char **argv)
-{
-  char *dylib = strcat(dirname(argv[0]),"/UnitTest.xctest/Contents/MacOS/test");
+int main(int argc, const char **argv) {
+  char dylib[PATH_MAX];
+  strlcpy(dylib, dirname(argv[0]), PATH_MAX);
+  strlcat(dylib, "/UnitTest.xctest/Contents/MacOS/test", PATH_MAX);
   void *test_case = dlopen(dylib, RTLD_NOW);
 
   printf("%p\n", test_case); // Set breakpoint here