Skip to content

Commit 1ada03a

Browse files
author
git apple-llvm automerger
committed
Merge commit 'b0093e13fcfd' from llvm.org/main into next
2 parents f5fbce7 + b0093e1 commit 1ada03a

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

llvm/lib/Target/AArch64/AArch64InstrInfo.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2228,6 +2228,7 @@ bool AArch64InstrInfo::hasUnscaledLdStOffset(unsigned Opc) {
22282228
case AArch64::LDRWpre:
22292229
case AArch64::LDURXi:
22302230
case AArch64::LDRXpre:
2231+
case AArch64::LDRSWpre:
22312232
case AArch64::LDURSWi:
22322233
case AArch64::LDURHHi:
22332234
case AArch64::LDURBBi:
@@ -2437,6 +2438,7 @@ bool AArch64InstrInfo::isPairableLdStInst(const MachineInstr &MI) {
24372438
case AArch64::LDURXi:
24382439
case AArch64::LDRXpre:
24392440
case AArch64::LDURSWi:
2441+
case AArch64::LDRSWpre:
24402442
return true;
24412443
}
24422444
}
@@ -2557,7 +2559,8 @@ bool AArch64InstrInfo::isCandidateToMergeOrPair(const MachineInstr &MI) const {
25572559
// Can't merge/pair if the instruction modifies the base register.
25582560
// e.g., ldr x0, [x0]
25592561
// This case will never occur with an FI base.
2560-
// However, if the instruction is an LDR/STR<S,D,Q,W,X>pre, it can be merged.
2562+
// However, if the instruction is an LDR<S,D,Q,W,X,SW>pre or
2563+
// STR<S,D,Q,W,X>pre, it can be merged.
25612564
// For example:
25622565
// ldr q0, [x11, #32]!
25632566
// ldr q1, [x11, #16]
@@ -3134,6 +3137,7 @@ int AArch64InstrInfo::getMemScale(unsigned Opc) {
31343137
case AArch64::LDRSpre:
31353138
case AArch64::LDRSWui:
31363139
case AArch64::LDURSWi:
3140+
case AArch64::LDRSWpre:
31373141
case AArch64::LDRWpre:
31383142
case AArch64::LDRWui:
31393143
case AArch64::LDURWi:
@@ -3189,6 +3193,7 @@ bool AArch64InstrInfo::isPreLd(const MachineInstr &MI) {
31893193
return false;
31903194
case AArch64::LDRWpre:
31913195
case AArch64::LDRXpre:
3196+
case AArch64::LDRSWpre:
31923197
case AArch64::LDRSpre:
31933198
case AArch64::LDRDpre:
31943199
case AArch64::LDRQpre:

llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,8 @@ static unsigned getMatchingNonSExtOpcode(unsigned Opc,
293293
return AArch64::LDRWui;
294294
case AArch64::LDURSWi:
295295
return AArch64::LDURWi;
296+
case AArch64::LDRSWpre:
297+
return AArch64::LDRWpre;
296298
}
297299
}
298300

@@ -372,6 +374,8 @@ static unsigned getMatchingPairOpcode(unsigned Opc) {
372374
case AArch64::LDRSWui:
373375
case AArch64::LDURSWi:
374376
return AArch64::LDPSWi;
377+
case AArch64::LDRSWpre:
378+
return AArch64::LDPSWpre;
375379
}
376380
}
377381

@@ -585,6 +589,8 @@ static bool isPreLdStPairCandidate(MachineInstr &FirstMI, MachineInstr &MI) {
585589
return (OpcB == AArch64::LDRWui) || (OpcB == AArch64::LDURWi);
586590
case AArch64::LDRXpre:
587591
return (OpcB == AArch64::LDRXui) || (OpcB == AArch64::LDURXi);
592+
case AArch64::LDRSWpre:
593+
return (OpcB == AArch64::LDRSWui) || (OpcB == AArch64::LDURSWi);
588594
}
589595
}
590596

@@ -1340,7 +1346,7 @@ static bool areCandidatesToMergeOrPair(MachineInstr &FirstMI, MachineInstr &MI,
13401346
return false;
13411347

13421348
// The STR<S,D,Q,W,X>pre - STR<S,D,Q,W,X>ui and
1343-
// LDR<S,D,Q,W,X>pre-LDR<S,D,Q,W,X>ui
1349+
// LDR<S,D,Q,W,X,SW>pre-LDR<S,D,Q,W,X,SW>ui
13441350
// are candidate pairs that can be merged.
13451351
if (isPreLdStPairCandidate(FirstMI, MI))
13461352
return true;

llvm/test/CodeGen/AArch64/ldrpre-ldr-merge.mir

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ body: |
588588

589589

590590
---
591-
name: 21-ldrswpre-ldrswui-no-merge
591+
name: 21-ldrswpre-ldrswui-merge
592592
tracksRegLiveness: true
593593
liveins:
594594
- { reg: '$x0' }
@@ -599,10 +599,9 @@ machineFunctionInfo:
599599
body: |
600600
bb.0:
601601
liveins: $x0, $x1, $x2
602-
; CHECK-LABEL: name: 21-ldrswpre-ldrswui-no-merge
602+
; CHECK-LABEL: name: 21-ldrswpre-ldrswui-merge
603603
; CHECK: liveins: $x0, $x1, $x2
604-
; CHECK: early-clobber renamable $x1, renamable $x0 = LDRSWpre renamable $x1, 40, implicit $w1 :: (load (s32))
605-
; CHECK: renamable $x2 = LDRSWui renamable $x1, 1 :: (load (s32))
604+
; CHECK: early-clobber $x1, renamable $x0, renamable $x2 = LDPSWpre renamable $x1, 10 :: (load (s32))
606605
; CHECK: STPXi renamable $x0, renamable $x2, renamable $x1, 0 :: (store (s64))
607606
; CHECK: RET undef $lr
608607
early-clobber renamable $x1, renamable $x0 = LDRSWpre killed renamable $x1, 40 :: (load (s32))
@@ -614,7 +613,7 @@ body: |
614613

615614

616615
---
617-
name: 22-ldrswpre-ldurswi-no-merge
616+
name: 22-ldrswpre-ldurswi-merge
618617
tracksRegLiveness: true
619618
liveins:
620619
- { reg: '$x0' }
@@ -625,10 +624,9 @@ machineFunctionInfo:
625624
body: |
626625
bb.0:
627626
liveins: $x0, $x1, $x2
628-
; CHECK-LABEL: name: 22-ldrswpre-ldurswi-no-merge
627+
; CHECK-LABEL: name: 22-ldrswpre-ldurswi-merge
629628
; CHECK: liveins: $x0, $x1, $x2
630-
; CHECK: early-clobber renamable $x1, renamable $x0 = LDRSWpre renamable $x1, 40, implicit $w1 :: (load (s32))
631-
; CHECK: renamable $x2 = LDURSWi renamable $x1, 4 :: (load (s32))
629+
; CHECK: early-clobber $x1, renamable $x0, renamable $x2 = LDPSWpre renamable $x1, 10 :: (load (s32))
632630
; CHECK: STPXi renamable $x0, renamable $x2, renamable $x1, 0 :: (store (s64))
633631
; CHECK: RET undef $lr
634632
early-clobber renamable $x1, renamable $x0 = LDRSWpre killed renamable $x1, 40 :: (load (s32))

0 commit comments

Comments
 (0)