Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values"

Reverted due to failure on the sanitizer-x86_64-linux-fast bot.

This reverts commit e10493e.

Author: SLTozer

llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h

@@ -138,9 +138,7 @@ class SDDbgValue {
 
 private:
   LocOpVector LocationOps;
-  // SDNode dependencies will be calculated as SDNodes that appear in
-  // LocationOps plus these AdditionalDependencies.
-  SDNodeVector AdditionalDependencies;
+  SDNodeVector SDNodes;
   DIVariable *Var;
   DIExpression *Expr;
   DebugLoc DL;
@@ -155,9 +153,8 @@ class SDDbgValue {
              ArrayRef<SDNode *> Dependencies, bool IsIndirect, DebugLoc DL,
              unsigned O, bool IsVariadic)
       : LocationOps(L.begin(), L.end()),
-        AdditionalDependencies(Dependencies.begin(), Dependencies.end()),
-        Var(Var), Expr(Expr), DL(DL), Order(O), IsIndirect(IsIndirect),
-        IsVariadic(IsVariadic) {
+        SDNodes(Dependencies.begin(), Dependencies.end()), Var(Var), Expr(Expr),
+        DL(DL), Order(O), IsIndirect(IsIndirect), IsVariadic(IsVariadic) {
     assert(IsVariadic || L.size() == 1);
     assert(!(IsVariadic && IsIndirect));
   }
@@ -173,18 +170,9 @@ class SDDbgValue {
   LocOpVector copyLocationOps() const { return LocationOps; }
 
   // Returns the SDNodes which this SDDbgValue depends on.
-  SDNodeVector getSDNodes() const {
-    SDNodeVector Dependencies;
-    for (SDDbgOperand DbgOp : LocationOps)
-      if (DbgOp.getKind() == SDDbgOperand::SDNODE)
-        Dependencies.push_back(DbgOp.getSDNode());
-    Dependencies.append(AdditionalDependencies);
-    return Dependencies;
-  }
+  ArrayRef<SDNode *> getSDNodes() const { return SDNodes; }
 
-  ArrayRef<SDNode *> getAdditionalDependencies() const {
-    return AdditionalDependencies;
-  }
+  SDNodeVector copySDNodes() const { return SDNodes; }
 
   /// Returns whether this is an indirect value.
   bool isIndirect() const { return IsIndirect; }

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

@@ -8583,7 +8583,7 @@ SDDbgValue *SelectionDAG::getDbgValue(DIVariable *Var, DIExpression *Expr,
   assert(cast<DILocalVariable>(Var)->isValidLocationForIntrinsic(DL) &&
          "Expected inlined-at fields to agree");
   return new (DbgInfo->getAlloc())
-      SDDbgValue(Var, Expr, SDDbgOperand::fromNode(N, R), {}, IsIndirect, DL, O,
+      SDDbgValue(Var, Expr, SDDbgOperand::fromNode(N, R), N, IsIndirect, DL, O,
                  /*IsVariadic=*/false);
 }
 
@@ -8707,10 +8707,12 @@ void SelectionDAG::transferDbgValues(SDValue From, SDValue To,
       Expr = *Fragment;
     }
 
-    auto AdditionalDependencies = Dbg->getAdditionalDependencies();
+    auto NewDependencies = Dbg->copySDNodes();
+    std::replace(NewDependencies.begin(), NewDependencies.end(), FromNode,
+                 ToNode);
     // Clone the SDDbgValue and move it to To.
     SDDbgValue *Clone = getDbgValueList(
-        Var, Expr, NewLocOps, AdditionalDependencies, Dbg->isIndirect(),
+        Var, Expr, NewLocOps, NewDependencies, Dbg->isIndirect(),
         Dbg->getDebugLoc(), std::max(ToNode->getIROrder(), Dbg->getOrder()),
         Dbg->isVariadic());
     ClonedDVs.push_back(Clone);
@@ -8770,9 +8772,11 @@ void SelectionDAG::salvageDebugInfo(SDNode &N) {
         (void)Changed;
         assert(Changed && "Salvage target doesn't use N");
 
-        auto AdditionalDependencies = DV->getAdditionalDependencies();
+        auto NewDependencies = DV->copySDNodes();
+        std::replace(NewDependencies.begin(), NewDependencies.end(), &N,
+                     N0.getNode());
         SDDbgValue *Clone = getDbgValueList(DV->getVariable(), DIExpr,
-                                            NewLocOps, AdditionalDependencies,
+                                            NewLocOps, NewDependencies,
                                             DV->isIndirect(), DV->getDebugLoc(),
                                             DV->getOrder(), DV->isVariadic());
         ClonedDVs.push_back(Clone);

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

@@ -1331,6 +1331,7 @@ bool SelectionDAGBuilder::handleDebugValue(ArrayRef<const Value *> Values,
       // Only emit func arg dbg value for non-variadic dbg.values for now.
       if (!IsVariadic && EmitFuncArgumentDbgValue(V, Var, Expr, dl, false, N))
         return true;
+      Dependencies.push_back(N.getNode());
       if (auto *FISDN = dyn_cast<FrameIndexSDNode>(N.getNode())) {
         // Construct a FrameIndexDbgValue for FrameIndexSDNodes so we can
         // describe stack slot locations.
@@ -1342,7 +1343,6 @@ bool SelectionDAGBuilder::handleDebugValue(ArrayRef<const Value *> Values,
         //   dbg.value(i32* %px, !"int x", !DIExpression(DW_OP_deref))
         //
         // Both describe the direct values of their associated variables.
-        Dependencies.push_back(N.getNode());
         LocationOps.emplace_back(SDDbgOperand::fromFrameIdx(FISDN->getIndex()));
         continue;
       }