Skip to content

Commit 1b812f9

Browse files
authored
[lldb] Log to system log instead of stderr from Host::SystemLog (llvm#83366)
Currently, calls to Host::SystemLog print to stderr on all host platforms except Darwin. This severely limits its value on the command line, where we don't want to overload the user with log messages. Switch to using the syslog function on POSIX systems to send messages to the system logger instead of stdout. On Darwin systems this sends the log message to os_log, which matches what we do today. Nevertheless I kept the current implementation that uses os_log directly as it gives us more freedom. I'm not sure if there's an equivalent on Windows, so I kept the existing behavior of logging to stderr.
1 parent 083d8aa commit 1b812f9

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

lldb/source/Host/common/Host.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,19 @@ using namespace lldb;
8989
using namespace lldb_private;
9090

9191
#if !defined(__APPLE__)
92+
#if !defined(_WIN32)
93+
#include <syslog.h>
94+
void Host::SystemLog(llvm::StringRef message) {
95+
static llvm::once_flag g_openlog_once;
96+
llvm::call_once(g_openlog_once, [] {
97+
openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
98+
});
99+
syslog(LOG_INFO, "%s", message.data());
100+
}
101+
#else
92102
void Host::SystemLog(llvm::StringRef message) { llvm::errs() << message; }
93103
#endif
104+
#endif
94105

95106
#if !defined(__APPLE__) && !defined(_WIN32)
96107
static thread_result_t

0 commit comments

Comments
 (0)