[llvm-lib] Pass the right value of MingwDef to parseCOFFModuleDefinition

mstorsjo · mstorsjo · commit 1d96e24dda2e · 2023-06-08T23:21:56.000+03:00
In llvm-lib cases, the MinGW specific behaviours shouldn't be enabled. Not adding any tests to check the corner case behaviours, as this simply was a mistake when this codepath was added in 395ec44 / D144765. Differential Revision: https://reviews.llvm.org/D152362
diff --git a/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp b/llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp
@@ -384,7 +384,7 @@ int llvm::libDriverMain(ArrayRef<const char *> ArgsArr) {
     }
 
     Expected<COFFModuleDefinition> Def =
-        parseCOFFModuleDefinition(*MB, LibMachine, true);
+        parseCOFFModuleDefinition(*MB, LibMachine, /*MingwDef=*/false);
 
     if (!Def) {
       llvm::errs() << "error parsing definition\n"

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ int llvm::libDriverMain(ArrayRef<const char *> ArgsArr) {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`Expected<COFFModuleDefinition> Def =`
`387`		`- parseCOFFModuleDefinition(*MB, LibMachine, true);`
	`387`	`+ parseCOFFModuleDefinition(MB, LibMachine, /MingwDef=*/false);`
`388`	`388`
`389`	`389`	`if (!Def) {`
`390`	`390`	`llvm::errs() << "error parsing definition\n"`