Hoist SwiftASTContext::IsIntegerType into TypeSystemSwift (NFC)

and add a unit test for it.

(cherry picked from commit 215c9c1)

Author: adrian-prantl

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -5061,11 +5061,6 @@ bool SwiftASTContext::IsFunctionPointerType(opaque_compiler_type_t type) {
   return IsFunctionType(type, nullptr); // FIXME: think about this
 }
 
-bool SwiftASTContext::IsIntegerType(opaque_compiler_type_t type,
-                                    bool &is_signed) {
-  return (GetTypeInfo(type, nullptr) & eTypeIsInteger);
-}
-
 bool SwiftASTContext::IsPointerType(opaque_compiler_type_t type,
                                     CompilerType *pointee_type) {
   VALID_OR_RETURN(false);

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h

@@ -460,9 +460,6 @@ class SwiftASTContext : public TypeSystemSwift {
 
   bool IsFunctionPointerType(lldb::opaque_compiler_type_t type) override;
 
-  bool IsIntegerType(lldb::opaque_compiler_type_t type,
-                     bool &is_signed) override;
-
   bool IsPossibleDynamicType(lldb::opaque_compiler_type_t type,
                              CompilerType *target_type, // Can pass NULL
                              bool check_cplusplus, bool check_objc) override;

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwift.cpp

@@ -76,3 +76,8 @@ bool TypeSystemSwift::IsFloatingPointType(opaque_compiler_type_t type,
   }
   return false;
 }
+
+bool TypeSystemSwift::IsIntegerType(opaque_compiler_type_t type,
+                                    bool &is_signed) {
+  return (GetTypeInfo(type, nullptr) & eTypeIsInteger);
+}

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwift.h

@@ -143,6 +143,8 @@ class TypeSystemSwift : public TypeSystem {
   bool IsConst(lldb::opaque_compiler_type_t type) override { return false; }
   bool IsFloatingPointType(lldb::opaque_compiler_type_t type, uint32_t &count,
                            bool &is_complex) override;
+  bool IsIntegerType(lldb::opaque_compiler_type_t type,
+                     bool &is_signed) override;
   bool IsCStringType(lldb::opaque_compiler_type_t type,
                      uint32_t &length) override {
     return false;

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

@@ -1341,10 +1341,6 @@ bool TypeSystemSwiftTypeRef::IsFunctionPointerType(
   VALIDATE_AND_RETURN(impl, IsFunctionPointerType, type,
                       (ReconstructType(type)));
 }
-bool TypeSystemSwiftTypeRef::IsIntegerType(opaque_compiler_type_t type,
-                                           bool &is_signed) {
-  return m_swift_ast_context->IsIntegerType(ReconstructType(type), is_signed);
-}
 bool TypeSystemSwiftTypeRef::IsPossibleDynamicType(opaque_compiler_type_t type,
                                                    CompilerType *target_type,
                                                    bool check_cplusplus,

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.h

@@ -95,8 +95,6 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift {
   CompilerType GetFunctionArgumentAtIndex(lldb::opaque_compiler_type_t type,
                                           const size_t index) override;
   bool IsFunctionPointerType(lldb::opaque_compiler_type_t type) override;
-  bool IsIntegerType(lldb::opaque_compiler_type_t type,
-                     bool &is_signed) override;
   bool IsPossibleDynamicType(lldb::opaque_compiler_type_t type,
                              CompilerType *target_type, // Can pass NULL
                              bool check_cplusplus, bool check_objc) override;

lldb/unittests/Symbol/TestTypeSystemSwiftTypeRef.cpp

@@ -289,7 +289,7 @@ TEST_F(TestTypeSystemSwiftTypeRef, Defined) {
   }
 }
 
-TEST_F(TestTypeSystemSwiftTypeRef, Float) {
+TEST_F(TestTypeSystemSwiftTypeRef, IntFloat) {
   using namespace swift::Demangle;
   Demangler dem;
   NodeBuilder b(dem);
@@ -301,6 +301,8 @@ TEST_F(TestTypeSystemSwiftTypeRef, Float) {
     ASSERT_FALSE(int_type.IsFloatingPointType(count, is_complex));
     ASSERT_EQ(count, 0);
     ASSERT_EQ(is_complex, false);
+    bool is_signed = true;
+    ASSERT_TRUE(int_type.IsIntegerType(is_signed));
   }
   {
     NodePointer float_node = b.GlobalTypeMangling(b.FloatType());
@@ -310,5 +312,7 @@ TEST_F(TestTypeSystemSwiftTypeRef, Float) {
     ASSERT_TRUE(float_type.IsFloatingPointType(count, is_complex));
     ASSERT_EQ(count, 1);
     ASSERT_EQ(is_complex, false);
+    bool is_signed = true;
+    ASSERT_FALSE(float_type.IsIntegerType(is_signed));
   }
 }