Skip to content

Commit 262e288

Browse files
committed
[compiler-rt] Fix MSVC /external detection in cmake scripts
As suggested by https://reviews.llvm.org/D116872#4650507 Differential Revision: https://reviews.llvm.org/D116872
1 parent acb6e85 commit 262e288

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

compiler-rt/lib/asan/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ append_rtti_flag(OFF ASAN_CFLAGS)
9292

9393
# Silence warnings in system headers with MSVC.
9494
if(NOT CLANG_CL)
95-
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external /external:W0 /external:anglebrackets" ASAN_CFLAGS)
95+
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external;/external:W0;/external:anglebrackets" ASAN_CFLAGS)
9696
endif()
9797

9898
# Too many existing bugs, needs cleanup.

compiler-rt/lib/interception/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ append_rtti_flag(OFF INTERCEPTION_CFLAGS)
2121

2222
# Silence warnings in system headers with MSVC.
2323
if(NOT CLANG_CL)
24-
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external /external:W0 /external:anglebrackets" INTERCEPTION_CFLAGS)
24+
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external;/external:W0;/external:anglebrackets" INTERCEPTION_CFLAGS)
2525
endif()
2626

2727
add_compiler_rt_object_libraries(RTInterception

compiler-rt/lib/ubsan/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_CXXFLAGS)
5757

5858
# Silence warnings in system headers with MSVC.
5959
if(NOT CLANG_CL)
60-
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external /external:W0 /external:anglebrackets" UBSAN_CXXFLAGS)
60+
append_list_if(COMPILER_RT_HAS_EXTERNAL_FLAG "/experimental:external;/external:W0;/external:anglebrackets" UBSAN_CXXFLAGS)
6161
endif()
6262

6363
set(UBSAN_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})

0 commit comments

Comments
 (0)