Simplify coro::salvageDebugInfo() (NFC-ish)

This patch removes the hand-rolled implementation of salvageDebugInfo
for cast and GEPs and replaces it with a call into
llvm::salvageDebugInfoImpl().

A side-effect of this is that additional redundant convert operations
are introduced, but those don't have any negative effect on the
resulting DWARF expression.

rdar://80227769

Differential Revision: https://reviews.llvm.org/D107384

(cherry picked from commit a353edb)

 Conflicts:
	llvm/lib/Transforms/Coroutines/CoroFrame.cpp

Author: adrian-prantl

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

@@ -2514,8 +2514,8 @@ void coro::salvageDebugInfo(
   bool OutermostLoad = true;
   Value *Storage = DVI->getVariableLocationOp(0);
   Value *OriginalStorage = Storage;
-  while (Storage) {
-    if (auto *LdInst = dyn_cast<LoadInst>(Storage)) {
+  while (auto *Inst = dyn_cast<Instruction>(Storage)) {
+    if (auto *LdInst = dyn_cast<LoadInst>(Inst)) {
       Storage = LdInst->getOperand(0);
       // FIXME: This is a heuristic that works around the fact that
       // LLVM IR debug intrinsics cannot yet distinguish between
@@ -2526,41 +2526,36 @@ void coro::salvageDebugInfo(
       if (!OutermostLoad)
         Expr = DIExpression::prepend(Expr, DIExpression::DerefBefore);
       OutermostLoad = false;
-    } else if (auto *StInst = dyn_cast<StoreInst>(Storage)) {
+    } else if (auto *StInst = dyn_cast<StoreInst>(Inst)) {
       Storage = StInst->getOperand(0);
-    } else if (auto *GEPInst = dyn_cast<GetElementPtrInst>(Storage)) {
-      SmallVector<uint64_t, 16> Ops;
-      SmallVector<Value *, 0> AdditionalValues;
-      Storage = llvm::salvageDebugInfoImpl(
-          *GEPInst, Expr ? Expr->getNumLocationOperands() : 0, Ops,
-          AdditionalValues);
-      if (!Storage)
-        break;
-      // Debug declares cannot currently handle additional location
-      // operands.
-      if (!AdditionalValues.empty())
-        break;
-      Expr = DIExpression::appendOpsToArg(Expr, Ops, 0, /*StackValue*/ false);
-    } else if (auto *BCInst = dyn_cast<llvm::BitCastInst>(Storage))
-      Storage = BCInst->getOperand(0);
-    } else if (auto *I2PInst = dyn_cast<llvm::IntToPtrInst>(Storage)) {
+    } else if (auto *I2PInst = dyn_cast<llvm::IntToPtrInst>(Inst)) {
       Storage = I2PInst->getOperand(0);
-    } else if (auto *P2IInst = dyn_cast<llvm::PtrToIntInst>(Storage)) {
+    } else if (auto *P2IInst = dyn_cast<llvm::PtrToIntInst>(Inst)) {
       Storage = P2IInst->getOperand(0);
-    } else if (auto *IInst = dyn_cast<llvm::IntrinsicInst>(Storage)) {
+    } else if (auto *IInst = dyn_cast<llvm::IntrinsicInst>(Inst)) {
       if (IInst->getIntrinsicID() == Intrinsic::ptrauth_auth)
         Storage = IInst->getArgOperand(0);
       else
         break;
-    } else if (auto *Phi = dyn_cast<PHINode>(Storage)) {
+    } else if (auto *Phi = dyn_cast<PHINode>(Inst)) {
       if (Phi->getNumIncomingValues() != 1)
         return;
       Storage = Phi->getIncomingValue(0);
-    } else
-      break;
+    } else {
+      SmallVector<uint64_t, 16> Ops;
+      SmallVector<Value *, 0> AdditionalValues;
+      Value *Op = llvm::salvageDebugInfoImpl(
+          *Inst, Expr ? Expr->getNumLocationOperands() : 0, Ops,
+          AdditionalValues);
+      if (!Op || !AdditionalValues.empty()) {
+        // If salvaging failed or salvaging produced more than one location
+        // operand, give up.
+        break;
+      }
+      Storage = Op;
+      Expr = DIExpression::appendOpsToArg(Expr, Ops, 0, /*StackValue*/ false);
+    }
   }
-  if (!Storage)
-    return;
 
   // Store a pointer to the coroutine frame object in an alloca so it
   // is available throughout the function when producing unoptimized

llvm/test/Transforms/Coroutines/coro-debug.ll

@@ -154,7 +154,7 @@ attributes #7 = { noduplicate }
 ; CHECK: call void @llvm.dbg.declare(metadata %f.Frame** %[[DBG_PTR]], metadata ![[RESUME_DIRECT:[0-9]+]], metadata !DIExpression(DW_OP_deref, DW_OP_plus_uconst, [[EXPR_TAIL]])
 ; CHECK: store %f.Frame* {{.*}}, %f.Frame** %[[DBG_PTR]]
 ; CHECK-NOT: alloca %struct.test*
-; CHECK: call void @llvm.dbg.declare(metadata i32 0, metadata ![[RESUME_CONST:[0-9]+]], metadata !DIExpression())
+; CHECK: call void @llvm.dbg.declare(metadata i8 0, metadata ![[RESUME_CONST:[0-9]+]], metadata !DIExpression(DW_OP_LLVM_convert, 8, DW_ATE_signed, DW_OP_LLVM_convert, 32, DW_ATE_signed))
 ; Note that keeping the undef value here could be acceptable, too.
 ; CHECK-NOT: call void @llvm.dbg.declare(metadata i32* undef, metadata !{{[0-9]+}}, metadata !DIExpression())
 ; CHECK: call void @coro.devirt.trigger(i8* null)