Skip to content

Commit 27e01d1

Browse files
authored
[X86] Use new Flags argument to storeRegToStackSlot to simplify code. NFC (llvm#124658)
Use the Flags argument to add FrameSetup directly instead of walking backwards to add the flag after the call.
1 parent 7fff252 commit 27e01d1

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

llvm/lib/Target/X86/X86FrameLowering.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3062,10 +3062,7 @@ bool X86FrameLowering::spillCalleeSavedRegisters(
30623062
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg, VT);
30633063

30643064
TII.storeRegToStackSlot(MBB, MI, Reg, true, I.getFrameIdx(), RC, TRI,
3065-
Register());
3066-
--MI;
3067-
MI->setFlag(MachineInstr::FrameSetup);
3068-
++MI;
3065+
Register(), MachineInstr::FrameSetup);
30693066
}
30703067

30713068
return true;

llvm/lib/Target/X86/X86InstrInfo.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4801,7 +4801,8 @@ void X86InstrInfo::storeRegToStackSlot(
48014801
loadStoreTileReg(MBB, MI, Opc, SrcReg, FrameIdx, isKill);
48024802
else
48034803
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc)), FrameIdx)
4804-
.addReg(SrcReg, getKillRegState(isKill));
4804+
.addReg(SrcReg, getKillRegState(isKill))
4805+
.setMIFlag(Flags);
48054806
}
48064807

48074808
void X86InstrInfo::loadRegFromStackSlot(
@@ -4821,8 +4822,8 @@ void X86InstrInfo::loadRegFromStackSlot(
48214822
if (isAMXOpcode(Opc))
48224823
loadStoreTileReg(MBB, MI, Opc, DestReg, FrameIdx);
48234824
else
4824-
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc), DestReg),
4825-
FrameIdx);
4825+
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc), DestReg), FrameIdx)
4826+
.setMIFlag(Flags);
48264827
}
48274828

48284829
bool X86InstrInfo::analyzeCompare(const MachineInstr &MI, Register &SrcReg,

0 commit comments

Comments
 (0)