[NFC][SimplifyCFG] HoistThenElseCodeToIf(): after hoisting terminator, do return Changed, not just true

LebedevRI · LebedevRI · commit 2815429d08fe · 2020-07-16T00:32:48.000+03:00
Otherwise, if Changed was still false before that,
we would not account for that hoist in NumHoistCommonCode statistic.
diff --git a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp
@@ -1422,6 +1422,7 @@ bool SimplifyCFGOpt::HoistThenElseCodeToIf(BranchInst *BI,
     I2->replaceAllUsesWith(NT);
     NT->takeName(I1);
   }
+  Changed = true;
   ++NumHoistCommonInstrs;
 
   // Ensure terminator gets a debug location, even an unknown one, in case
@@ -1469,7 +1470,7 @@ bool SimplifyCFGOpt::HoistThenElseCodeToIf(BranchInst *BI,
     AddPredecessorToBlock(Succ, BIParent, BB1);
 
   EraseTerminatorAndDCECond(BI);
-  return true;
+  return Changed;
 }
 
 // Check lifetime markers.

Original file line number	Diff line number	Diff line change
`@@ -1422,6 +1422,7 @@ bool SimplifyCFGOpt::HoistThenElseCodeToIf(BranchInst *BI,`
`1422`	`1422`	`I2->replaceAllUsesWith(NT);`
`1423`	`1423`	`NT->takeName(I1);`
`1424`	`1424`	`}`
	`1425`	`+ Changed = true;`
`1425`	`1426`	`++NumHoistCommonInstrs;`
`1426`	`1427`
`1427`	`1428`	`// Ensure terminator gets a debug location, even an unknown one, in case`
`@@ -1469,7 +1470,7 @@ bool SimplifyCFGOpt::HoistThenElseCodeToIf(BranchInst *BI,`
`1469`	`1470`	`AddPredecessorToBlock(Succ, BIParent, BB1);`
`1470`	`1471`
`1471`	`1472`	`EraseTerminatorAndDCECond(BI);`
`1472`		`- return true;`
	`1473`	`+ return Changed;`
`1473`	`1474`	`}`
`1474`	`1475`
`1475`	`1476`	`// Check lifetime markers.`